Fix up vec guarnatee around capacity #41535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This LGTM (I feel like I've probably relied on this property at one point or another), but would like other opinions. |
|
Yeah this the crux of the "read into an uninitialized buffer" strategy, so I feel like we're required to have this property hold! @bors: r+ |
|
📌 Commit 19b7272 has been approved by |
|
@bors rollup |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Apr 25, 2017
Fix up vec guarnatee around capacity Fixes rust-lang#37746 r? @rust-lang/libs
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 26, 2017
Fix up vec guarnatee around capacity Fixes rust-lang#37746 r? @rust-lang/libs
bors
added a commit
that referenced
this pull request
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37746
r? @rust-lang/libs