Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLVM: Update submodule to fix incorrect codegen on MSP430. #41556

Merged
merged 1 commit into from
Apr 28, 2017
Merged

LLVM: Update submodule to fix incorrect codegen on MSP430. #41556

merged 1 commit into from
Apr 28, 2017

Conversation

pftbest
Copy link
Contributor

@pftbest pftbest commented Apr 26, 2017 •
edited
Loading

The bug was reported by @akovaski here:
rust-embedded/wg#20 (comment)

P.S. Looks like this patch will conflict with Hexagon changes.

r? @alexcrichton

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 26, 2017

📌 Commit 7e2f3d8 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Apr 27, 2017

☔ The latest upstream changes (presumably #41567) made this pull request unmergeable. Please resolve the merge conflicts.

@pftbest
Copy link
Contributor Author

pftbest commented Apr 27, 2017

Fixed merge conflict.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 27, 2017

📌 Commit ec5588b has been approved by alexcrichton

arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 27, 2017
Rollup merge of rust-lang#41556 - pftbest:fix_msp430_codegen, r=alexc…
b83da2d 
…richton

LLVM: Update submodule to fix incorrect codegen on MSP430.

The bug was reported by @akovaski here:
rust-embedded/wg#20 (comment)

~~P.S. Looks like this patch will conflict with Hexagon changes.~~

r? @alexcrichton
@arielb1 arielb1 mentioned this pull request Apr 27, 2017
Closed
@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 27, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 27, 2017
@frewsxcv
Rollup merge of rust-lang#41556 - pftbest:fix_msp430_codegen, r=alexc…
f469c4a 
…richton

LLVM: Update submodule to fix incorrect codegen on MSP430.

The bug was reported by @akovaski here:
rust-embedded/wg#20 (comment)

~~P.S. Looks like this patch will conflict with Hexagon changes.~~

r? @alexcrichton
@frewsxcv frewsxcv mentioned this pull request Apr 27, 2017
Merged
bors added a commit that referenced this pull request Apr 28, 2017
@bors
Auto merge of #41591 - frewsxcv:rollup, r=frewsxcv
70baf4f 
Rollup of 7 pull requests

- Successful merges: #41438, #41523, #41526, #41546, #41556, #41572, #41578
- Failed merges:
@bors bors merged commit ec5588b into rust-lang:master Apr 28, 2017
@pftbest pftbest deleted the fix_msp430_codegen branch July 23, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pftbest @rust-highfive @alexcrichton @bors