Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a load rather than a fence when dropping the contents of an Arc. #41714

Closed
wants to merge 2 commits into from
Closed

Use a load rather than a fence when dropping the contents of an Arc. #41714

wants to merge 2 commits into from

Commits on May 2, 2017

  1. Use a load rather than a fence when dropping the contents of an Arc. 

    This is what Gecko does [1]. If I understand correctly, an Acquire load on
an address just needs to synchronize with other Release operations on that
specific address, whereas an Acquire fence needs to synchronize globally
with all other Release operations in the program.

[1] http://searchfox.org/mozilla-central/rev/ae8c2e2354db652950fe0ec16983360c21857f2a/xpcom/base/nsISupportsImpl.h#337
    @bholley
    bholley committed May 2, 2017
    Configuration menu
    Copy the full SHA
    75e6660 View commit details
    Browse the repository at this point in the history

  2. Document the reasoning for the Acquire/Release handshake when droppin… 

    …g Arcs.
    @bholley
    bholley committed May 2, 2017
    Configuration menu
    Copy the full SHA
    b533756 View commit details
    Browse the repository at this point in the history