Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #41762

Merged
merged 10 commits into from
May 5, 2017
Merged

Rollup of 4 pull requests #41762

merged 10 commits into from
May 5, 2017

Conversation

rap2hpoutre and others added 10 commits May 4, 2017 11:11
The bound is not required for compiling but it prevents using `next_token()` from a trait object.

Fixes rust-lang#33506.
join method returns a thread::Result

Join method returns a std::thread::Result, not a std::result::Result: https://doc.rust-lang.org/std/thread/struct.JoinHandle.html#method.join Maybe I misunderstood something.

I have seen this mistake(?) because I wanted to tackle this issue rust-lang#29378 (about Result). It's still one of my first PR. Sorry if I missed something.
Remove use of `Self: Sized` from libsyntax

The bound is not required for compiling but it prevents using `next_token()` from a trait object.

Fixes rust-lang#33506.
…uillaumeGomez

Simplify types in `std::option` doc comment example.

None
…, r=arielb1

kill some unused fields in TyCtxt
@frewsxcv
Copy link
Member Author

frewsxcv commented May 5, 2017

@bors r+ p=10

@bors
Copy link
Collaborator

bors commented May 5, 2017

📌 Commit 3cd7f37 has been approved by frewsxcv

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bors
Copy link
Collaborator

bors commented May 5, 2017

⌛ Testing commit 3cd7f37 with merge a6ab049...

bors added a commit that referenced this pull request May 5, 2017
Rollup of 4 pull requests

- Successful merges: #41741, #41746, #41749, #41754
- Failed merges:
@bors
Copy link
Collaborator

bors commented May 5, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing a6ab049 to master...

@bors bors merged commit 3cd7f37 into rust-lang:master May 5, 2017
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants