-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #41762
Rollup of 4 pull requests #41762
Conversation
The bound is not required for compiling but it prevents using `next_token()` from a trait object. Fixes rust-lang#33506.
join method returns a thread::Result Join method returns a std::thread::Result, not a std::result::Result: https://doc.rust-lang.org/std/thread/struct.JoinHandle.html#method.join Maybe I misunderstood something. I have seen this mistake(?) because I wanted to tackle this issue rust-lang#29378 (about Result). It's still one of my first PR. Sorry if I missed something.
Remove use of `Self: Sized` from libsyntax The bound is not required for compiling but it prevents using `next_token()` from a trait object. Fixes rust-lang#33506.
…uillaumeGomez Simplify types in `std::option` doc comment example. None
…, r=arielb1 kill some unused fields in TyCtxt
@bors r+ p=10 |
📌 Commit 3cd7f37 has been approved by |
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
☀️ Test successful - status-appveyor, status-travis |
Self: Sized
from libsyntax #41746, Simplify types instd::option
doc comment example. #41749, kill some unused fields in TyCtxt #41754