Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unicode Python script into libstd_unicode crate. #41763

Merged
merged 1 commit into from
May 6, 2017

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented May 5, 2017

The only place this Python script is used is inside the libstd_unicode
crate, so lets move it there.

The only place this Python script is used is inside the libstd_unicode
crate, so lets move it there.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

Nice!

If you're feeling adventurous, want to open an issue for translating this to the build script as well?

@bors
Copy link
Contributor

bors commented May 5, 2017

📌 Commit ed1b78c has been approved by alexcrichton

@hanna-kruppe
Copy link
Contributor

Many of the scripts in src/etc are only used from one place. I've considered it a dumping place for this sort of generator scripts. If we instead want build-time scripts to be stored in the crate they're related to, we should be consistent about it. (Obviously that doesn't have to happen in this PR but a I-cleanup issue would be good.)

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 5, 2017
@frewsxcv
Copy link
Member Author

frewsxcv commented May 5, 2017

If you're feeling adventurous, want to open an issue for translating this to the build script as well?

Assuming what you mean is that we should call this Python file whenever we build this crate to generate that file (or something along those lines), one downside is that it creates another network dependency, which isn't great. Not a show stopper, but worth pointing out

@alexcrichton
Copy link
Member

@frewsxcv oh sorry to clarify what I meant was actually rewriting the python logic in Rust, basically translating it into the build script.

I had forgotten about the network dependency though! In that case let's just leave it be.

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 5, 2017
Move unicode Python script into libstd_unicode crate.

The only place this Python script is used is inside the libstd_unicode
crate, so lets move it there.
bors added a commit that referenced this pull request May 5, 2017
Rollup of 9 pull requests

- Successful merges: #41064, #41307, #41512, #41582, #41678, #41722, #41734, #41761, #41763
- Failed merges:
@bors bors merged commit ed1b78c into rust-lang:master May 6, 2017
@bors
Copy link
Contributor

bors commented May 6, 2017

⌛ Testing commit ed1b78c with merge 42a4f37...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants