-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "an" usage #41786
Fix "an" usage #41786
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks! @bors r+ rollup |
📌 Commit a257d5a has been approved by |
@bors retry |
⌛ Testing commit a257d5a with merge 809b536... |
@bors r- Looks like this hit a test failure: https://travis-ci.org/rust-lang/rust/jobs/229448947 (view the raw log an scroll near the bottom) We have 'ui tests' that test the error/warning output for rust code. For example, for: https://github.com/rust-lang/rust/blob/master/src/test/ui/did_you_mean/issue-41679.rs we have: You'll need to update that '.stderr' file with your 'an' changes |
@bors retry Since this will fail anyway, prioritize another PR. |
Forgot that you have the change these things as well, but thanks for reminding me. |
@bors r=frewsxcv |
📌 Commit bb34a3e has been approved by |
Fix "an" usage Since the pr i reviewed on got merged way before the author had a chance to quickly change it, i just did it myself. (Or well, someone else asked me to, if you want me to be honest)
☀️ Test successful - status-appveyor, status-travis |
Since the pr i reviewed on got merged way before the author had a chance to quickly change it, i just did it myself. (Or well, someone else asked me to, if you want me to be honest)