Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "an" usage #41786

Merged
merged 2 commits into from
May 6, 2017
Merged

Fix "an" usage #41786

merged 2 commits into from
May 6, 2017

Conversation

arqunis
Copy link
Contributor

@arqunis arqunis commented May 6, 2017

Since the pr i reviewed on got merged way before the author had a chance to quickly change it, i just did it myself. (Or well, someone else asked me to, if you want me to be honest)

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member

frewsxcv commented May 6, 2017

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 6, 2017

📌 Commit a257d5a has been approved by frewsxcv

@Mark-Simulacrum
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented May 6, 2017

⌛ Testing commit a257d5a with merge 809b536...

@frewsxcv
Copy link
Member

frewsxcv commented May 6, 2017

@bors r-

Looks like this hit a test failure: https://travis-ci.org/rust-lang/rust/jobs/229448947 (view the raw log an scroll near the bottom)

We have 'ui tests' that test the error/warning output for rust code. For example, for:

https://github.com/rust-lang/rust/blob/master/src/test/ui/did_you_mean/issue-41679.rs

we have:

https://github.com/rust-lang/rust/blob/master/src/test/ui/did_you_mean/issue-41679.stderr

You'll need to update that '.stderr' file with your 'an' changes

@TimNN
Copy link
Contributor

TimNN commented May 6, 2017

@bors retry

Since this will fail anyway, prioritize another PR.

@arqunis
Copy link
Contributor Author

arqunis commented May 6, 2017

Forgot that you have the change these things as well, but thanks for reminding me.

@Mark-Simulacrum
Copy link
Member

@bors r=frewsxcv

@bors
Copy link
Contributor

bors commented May 6, 2017

📌 Commit bb34a3e has been approved by frewsxcv

@bors
Copy link
Contributor

bors commented May 6, 2017

⌛ Testing commit bb34a3e with merge c1a960a...

bors added a commit that referenced this pull request May 6, 2017
Fix "an" usage

Since the pr i reviewed on got merged way before the author had a chance to quickly change it, i just did it myself. (Or well, someone else asked me to, if you want me to be honest)
@bors
Copy link
Contributor

bors commented May 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing c1a960a to master...

@bors bors merged commit bb34a3e into rust-lang:master May 6, 2017
@arqunis arqunis deleted the an_to_a branch November 20, 2017 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants