Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed argument inference for closures when coercing into 'fn' #41838

Merged
merged 5 commits into from May 9, 2017
Merged

Fixed argument inference for closures when coercing into 'fn' #41838

merged 5 commits into from May 9, 2017

Conversation

ghost
Copy link

@ghost ghost commented May 8, 2017

This fixes #41755. The tests compile-fail/closure-no-fn.rs and compile-fail/issue-40000.rs were modified. A new test run-pass/closure_to_fn_coercion-expected-types.rs was added

r? @nikomatsakis

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 8, 2017

📌 Commit 82e0736 has been approved by nikomatsakis

frewsxcv added a commit to frewsxcv/rust that referenced this pull request May 9, 2017
…, r=nikomatsakis

Fixed argument inference for closures when coercing into 'fn'

This fixes rust-lang#41755. The tests  `compile-fail/closure-no-fn.rs` and `compile-fail/issue-40000.rs` were modified. A new test `run-pass/closure_to_fn_coercion-expected-types.rs` was added

r? @nikomatsakis
bors added a commit that referenced this pull request May 9, 2017
Rollup of 8 pull requests

- Successful merges: #41293, #41520, #41827, #41828, #41833, #41836, #41838, #41842
- Failed merges:
@bors bors merged commit 82e0736 into rust-lang:master May 9, 2017
@bors
Copy link
Contributor

bors commented May 9, 2017

⌛ Testing commit 82e0736 with merge bedd7da...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expected types of closure arguments are not inferred when coercing to a fn
3 participants