Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Backport #41666 for bigendian metadata serialisation #41844

Closed
wants to merge 1 commit into from

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented May 9, 2017

This is a trivial backport of beta-accepted #41666.

I compiled this on PPC to check and it seems to work, but not sure whether I didn't mess up
anything in a major way.

Maybe a good shot at rust-lang#41443
@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@cuviper
Copy link
Member Author

cuviper commented May 9, 2017

Here's a Fedora scratch build with the patch, showing success on ppc64 (bigendian) and ppc64le:
https://koji.fedoraproject.org/koji/taskinfo?taskID=19464406

@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2017
@cuviper
Copy link
Member Author

cuviper commented May 11, 2017

#41899 included the same backport.

@cuviper cuviper closed this May 11, 2017
@cuviper cuviper deleted the beta-pr41666 branch October 19, 2017 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants