-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustbuild: add support for --bindir and --sysconfdir #41853
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Fixes #41644 |
Hi @Keruspe, thanks for the PR! We'll periodically check in on it to make sure that @alexcrichton or someone else from the team reviews it soon once it is ready. By the way, could you add the |
Thanks! Looks good to me, r=me with the fix @TimNN mentioned and I think you'll need to remove "WIP" from the title as well |
Well the "WIP" is there because it's missing the rust-installer part for this to actually do something, but I can remove it now I you prefer |
Oh sorry about that! I just merged that PR |
Thanks! I guess this depends on #41843 now |
Ok cool, I'll r+ once that merges |
I'll probably have a few trivial conflicts to handle, do you prefer a merge or a rebase in this case? |
Eh either's fine, but I'd slightly prefer a rebase personally |
☔ The latest upstream changes (presumably #41843) made this pull request unmergeable. Please resolve the merge conflicts. |
Note the rust-installer submodule moved under src/tools/, and now includes your changes already as I had to update again for a different fix. |
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
@cuviper yup, saw that, thanks. Currently testing the rebased version |
@alexcrichton for my tests to pass correctly, I would need this to be merged: alexcrichton/xz2-rs#5 |
@alexcrichton Rebased on top of the rusty rust-installer. Works fine when DESTDIR is not set in the current state, and with DESTDIR set with the xz2-rs patch applied. |
Ok I've just published a new version of lzma-sys, want to update that and I'll r+? |
fixes build when DESTDIR is set Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Done, thanks |
@bors: r+ |
📌 Commit 08cc29e has been approved by |
rustbuild: add support for --bindir and --sysconfdir This depends on rust-lang/rust-installer#59 and we'll need to udpate the rust-installer submodule once it gets merged for it to work Fixes #41644
☀️ Test successful - status-appveyor, status-travis |
This depends on rust-lang/rust-installer#59 and we'll need to udpate the rust-installer submodule once it gets merged for it to work
Fixes #41644