Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass static crt to llvm cmake configuration #41959

Closed
wants to merge 6 commits into from
Closed

Pass static crt to llvm cmake configuration #41959

wants to merge 6 commits into from

Conversation

liranringel
Copy link
Contributor

Solves #40246

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@liranringel
Copy link
Contributor Author

r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned aturon May 12, 2017
@alexcrichton
Copy link
Member

Thanks @liranringel! It looks like there's a number of submodule updates here as well, were those intentional? If not, perhaps they could be backed out? (I think some are submodule deletions as well)

Also, it looks like you may have run cargo update? Perhaps that could be deferred to a different PR? We tend to prefer minor incremental updates to the Cargo.lock if possible

@liranringel
Copy link
Contributor Author

Ah this branch is a mess. I'll delete it and submit a new PR.

@liranringel liranringel deleted the pass-static-crt-to-llvm-cmake-config branch May 13, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants