Fix #35829 (quote!() does not handle br#"…"#)
#41961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
changed the title
quote!() does not handle b"…")quote!() does not handle b"…")
|
|
|
Turns out I've added the test to the wrong file 😂. Will fix proc_macro as well. @petrochenkov |
…le b"…") * Handles `b"…"`, `br#"…"#` and `...` for `quote_expr!()`. * Refactored the match statement to allow it to complain loudly on any unhandled token. * Similarly, proc_macro's `quote!()` did not handle `br#"…"#` or `r#"…"#`, so this commit fixes it too.
kennytm
changed the title
quote!() does not handle b"…")quote!() does not handle br#"…"#)
|
proc_macro also fixed; Travis passed @petrochenkov |
Mark-Simulacrum
added
the
S-waiting-on-review
|
ping @petrochenkov for review |
|
@bors r+ |
|
📌 Commit 115854e has been approved by |
bors
added a commit
that referenced
this pull request
May 17, 2017
Fix #35829 (`quote!()` does not handle `br#"…"#`) Fix issue #35829 (syntax extension's `quote_expr!()` does not handle `b"…"` and proc_macro's `quote!()` does not handle `r#"…"#`) * Handles `b"…"`, `br#"…"#` and `...` for `quote_expr!()`. * Refactored the match statement to allow it to complain loudly on any unhandled token. * Similarly, proc_macro's `quote!()` did not handle `br#"…"#` or `r#"…"#`, so this PR fixes it too.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #35829 (syntax extension's
quote_expr!()does not handleb"…"and proc_macro'squote!()does not handler#"…"#)b"…",br#"…"#and...forquote_expr!().quote!()did not handlebr#"…"#orr#"…"#, so this PR fixes it too.