Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add thiscall calling convention support #42058

Merged
merged 1 commit into from
May 26, 2017
Merged

add thiscall calling convention support #42058

merged 1 commit into from
May 26, 2017

Conversation

froydnj
Copy link
Contributor

@froydnj froydnj commented May 17, 2017

This support is needed for bindgen to work well on 32-bit Windows, and also enables people to begin experimenting with C++ FFI support on that platform.

Fixes #42044.

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@aidanhs aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2017
@aidanhs
Copy link
Member

aidanhs commented May 18, 2017

Thanks for the PR @froydnj, we'll make sure it gets reviewed by @pnkfelix or another reviewer soon!

@carols10cents
Copy link
Member

ping @pnkfelix, pinging you on irc too!

@arielb1 arielb1 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 23, 2017
@arielb1
Copy link
Contributor

arielb1 commented May 23, 2017

r? @japaric

Actually, I might go and review this myself tomorrow.

@sophiajt sophiajt mentioned this pull request May 23, 2017
Open
nikomatsakis
nikomatsakis requested changes May 24, 2017
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with some text in the unstable book, bonus points for opening an issue, but I can do that later

src/doc/unstable-book/src/language-features/abi-thiscall.md Outdated
@@ -0,0 +1,7 @@
# `abi_thiscall`

The tracking issue for this feature is: none.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a tracking issue for this? I think it'd be fine to have one tracking issue covering all the various unstable ABIs. It'd also be nice to actually put a few words in there about what the purpose of this ABI is. If we're going to have a book we might as well write something in it. =)

@froydnj froydnj mentioned this pull request May 24, 2017
Closed
@froydnj
add thiscall calling convention support
9a2e245 
This support is needed for bindgen to work well on 32-bit Windows, and
also enables people to begin experimenting with C++ FFI support on that
platform.

Fixes rust-lang#42044.
@froydnj froydnj force-pushed the thiscall-support branch from 4c22f27 to 9a2e245 Compare May 24, 2017 21:03
@froydnj
Copy link
Contributor Author

froydnj commented May 24, 2017

Thanks for the review! Added a bit of text to the book, along with a link to the tracking issue.

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 25, 2017

📌 Commit 9a2e245 has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented May 25, 2017

⌛ Testing commit 9a2e245 with merge 35ac065...

@bors
Copy link
Contributor

bors commented May 25, 2017

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented May 26, 2017

⌛ Testing commit 9a2e245 with merge 2db17c8...

bors added a commit that referenced this pull request May 26, 2017
@bors
Auto merge of #42058 - froydnj:thiscall-support, r=nikomatsakis
2db17c8 
add thiscall calling convention support

This support is needed for bindgen to work well on 32-bit Windows, and also enables people to begin experimenting with C++ FFI support on that platform.

Fixes #42044.
@bors
Copy link
Contributor

bors commented May 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 2db17c8 to master...

@bors bors merged commit 9a2e245 into rust-lang:master May 26, 2017
@bors bors mentioned this pull request May 26, 2017
Closed
@pravic pravic mentioned this pull request Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@froydnj @rust-highfive @aidanhs @carols10cents @arielb1 @nikomatsakis @bors @alexcrichton @pnkfelix