Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some clippy warnings in librustc_errors #42093

Merged
merged 1 commit into from
May 21, 2017

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented May 18, 2017

Again, those are small changes to improve readability.

@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 19, 2017
@arielb1
Copy link
Contributor

arielb1 commented May 19, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 19, 2017

📌 Commit fc51386 has been approved by arielb1

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2017
@bors
Copy link
Contributor

bors commented May 20, 2017

⌛ Testing commit fc51386 with merge b3cf1a8...

bors added a commit that referenced this pull request May 20, 2017
fix some clippy warnings in librustc_errors

Again, those are small changes to improve readability.
@bors
Copy link
Contributor

bors commented May 20, 2017

💔 Test failed - status-travis

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented May 20, 2017

Presumably a spurious failure, though of course we don't actually have the build.log it mentions as far as I know:

[00:26:22] ERROR: An error was encountered with the build.
[INFO ]  Performing some trivial sanity checks
[INFO ]  Build started 20170520.061733
[INFO ]  Building environment variables
[INFO ]  =================================================================
[INFO ]  Retrieving needed toolchain components' tarballs
[ERROR]
[ERROR]  >>
[ERROR]  >>  Build failed in step 'Retrieving needed toolchain components' tarballs'
[ERROR]  >>        called in step '(top-level)'
[ERROR]  >>
[ERROR]  >>  Error happened in: do_isl_get[scripts/build/companion_libs/121-isl.sh@741]
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]
[ERROR]  >>        called from: main[scripts/crosstool-NG.sh@591]
[ERROR]  >>
[ERROR]  >>  For more info on this error, look at the file: 'build.log'
[ERROR]  >>  There is a list of known issues, some with workarounds, in:
[ERROR]  >>      '/usr/local/share/doc/crosstool-ng/crosstool-ng-1.22.0/B - Known issues.txt'
[ERROR]
[ERROR]  (elapsed: 4:53.35)
[04:54] / make: *** [build] Error 1
[00:26:22] The command '/bin/sh -c ./build-toolchains.sh' returned a non-zero code: 1
[00:26:22] The command has failed after 5 attempts.

@bors retry

Edit: looks like a network failure actually

@llogiq
Copy link
Contributor Author

llogiq commented May 20, 2017

Yeah, doesn't look related.

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 20, 2017
…ielb1

fix some clippy warnings in librustc_errors

Again, those are small changes to improve readability.
bors added a commit that referenced this pull request May 21, 2017
Rollup of 6 pull requests

- Successful merges: #41892, #42062, #42091, #42093, #42098, #42127
- Failed merges:
@bors bors merged commit fc51386 into rust-lang:master May 21, 2017
@llogiq llogiq deleted the clippy-librustc_errors branch May 22, 2017 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants