-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Remove --crate-type=metadata deprecation warning #42277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Looks like there's a warning you'll need to fix:
|
@Mark-Simulacrum I know, thanks. Basically just did that in a rush earlier and pushed it up, figured I'll look at the Travis output later. I can't seem to manage labels, can you change it to |
a4e07d9
to
74441a3
Compare
@Mark-Simulacrum I removed the let emit_metadata = false;
...
return Ok((crate_types, emit_metadata)); It's only called in one location in the same file (line 1357) and I think it might be better to completely remove it. |
Yeah, remove |
74441a3
to
81f2735
Compare
Just FYI, I'm working my way through this. Properly removing the flag instead of having it permanently set to false is somewhat more effort than originally outlined in the mentoring description, but seems to be worth it. |
6c34587
to
582d350
Compare
src/test/run-pass/auxiliary/rmeta_rmeta.rs and src/test/run-pass/rmeta.rs need to be deleted since they are testing |
582d350
to
28069d0
Compare
@Mark-Simulacrum |
Actually, I think I lied; we do want to keep |
a31ec08
to
050a10f
Compare
@Mark-Simulacrum I went back to a very early version of this PR, basically just removing the code snippet that had the deprecation warning, the related |
050a10f
to
9873acc
Compare
@Mark-Simulacrum This PR is |
@bors r+ -- thanks @citizen428 ! |
📌 Commit 9873acc has been approved by |
@bors rollup |
…ta, r=nikomatsakis Remove --crate-type=metadata deprecation warning Fixes rust-lang#38640
Fixes #38640