Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate dll file name based on target os. issue #4119 #4237

Closed
wants to merge 55 commits into from

Conversation

ILyoan
Copy link
Contributor

@ILyoan ILyoan commented Dec 20, 2012

generate dll file name base on the given target os, using core::os::consts which now contains constant values for all of the supported targets.

@ILyoan
Copy link
Contributor Author

ILyoan commented Dec 20, 2012

@Lenny222 that is fixed in 658420a sorry for confusing

@graydon
Copy link
Contributor

graydon commented Dec 20, 2012

We actually support string constants now (&static/str) so these don't need to be functions anymore.

@ILyoan
Copy link
Contributor Author

ILyoan commented Dec 21, 2012

@graydon OK thanks I'll change the functions on core::os::consts to constants.
fn sysname() -> ~str { ~"linux" } will be const SYSNAME: &str = "linux"

how about family() and arch()?
should I change them as well?

@brson
Copy link
Contributor

brson commented Dec 28, 2012

@ILyoan I think yes.

gareth and others added 27 commits December 29, 2012 11:44
doc: make small corrections to tutorial
Remove semicolons at the end of macro_rules! definitions that cause compile failure
doc: Fix some typos in the tutorial and reference manual
…-len

reset LinearMap.size when expanding buckets
Add some extra description for std::net
@ILyoan
Copy link
Contributor Author

ILyoan commented Jan 2, 2013

Oops~
I think I ruined the pull request branch and this thread :(
Let me reopen thread..

@ILyoan ILyoan closed this Jan 2, 2013
@ILyoan ILyoan deleted the i4119 branch January 2, 2013 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.