Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E0603 error code #42387

Merged
merged 1 commit into from
Jun 3, 2017
Merged

Conversation

GuillaumeGomez
Copy link
Member

Part of #42229.

cc @Susurrus

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@Susurrus
Copy link
Contributor

Susurrus commented Jun 2, 2017

Is "item" the right word to use here or is there a more proper one? Seems like this error is specifically for "variables" or whatever the equivalent word is that's used in the Rust literature. Item seems too general.

@GuillaumeGomez
Copy link
Member Author

Variable/const/struct/enum/module -> item seems fine :p

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 2, 2017
@Susurrus
Copy link
Contributor

Susurrus commented Jun 3, 2017

Then LGTM.

@GuillaumeGomez
Copy link
Member Author

Thanks for your review! :)

@bors: r=Susurrus

@bors
Copy link
Contributor

bors commented Jun 3, 2017

📌 Commit 6675bb3 has been approved by Susurrus

@bors
Copy link
Contributor

bors commented Jun 3, 2017

⌛ Testing commit 6675bb3 with merge 6684d17...

bors added a commit that referenced this pull request Jun 3, 2017
@bors
Copy link
Contributor

bors commented Jun 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Susurrus
Pushing 6684d17 to master...

@bors bors merged commit 6675bb3 into rust-lang:master Jun 3, 2017
@GuillaumeGomez GuillaumeGomez deleted the error-codes-next branch June 3, 2017 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants