Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #42554

Closed
wants to merge 0 commits into from
Closed

Rollup of 4 pull requests #42554

wants to merge 0 commits into from

Conversation

@frewsxcv
Copy link
Member Author

frewsxcv commented Jun 9, 2017

@bors r+ p=10

@bors
Copy link
Contributor

bors commented Jun 9, 2017

📌 Commit e17ea99 has been approved by frewsxcv

@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bors
Copy link
Contributor

bors commented Jun 9, 2017

⌛ Testing commit e17ea99 with merge 731a6db...

@bors
Copy link
Contributor

bors commented Jun 9, 2017

💔 Test failed - status-appveyor

@kennytm
Copy link
Member

kennytm commented Jun 9, 2017

libstd test failed on i686-pc-windows-msvc. Spurious?

thread '<unnamed>' panicked at 'assertion failed: a - Duration::new(0, 100) <= b', src\libstd\time\mod.rs:473
test time::tests::instant_math ... FAILED

failures:
    time::tests::instant_math
test result: FAILED. 787 passed; 1 failed; 2 ignored; 0 measured; 0 filtered out

src/libstd/time/mod.rs:473:

    #[test]
    fn instant_math() {
        let a = Instant::now();
        let b = Instant::now();
        let dur = b.duration_since(a);
        assert_almost_eq!(b - dur, a);   // <-- line 473
        assert_almost_eq!(a + dur, b);

        let second = Duration::new(1, 0);
        assert_almost_eq!(a - second + second, a);
    }

@frewsxcv
Copy link
Member Author

frewsxcv commented Jun 9, 2017

Seems that way

@bors retry

@bors
Copy link
Contributor

bors commented Jun 9, 2017

⌛ Testing commit e17ea99 with merge fe85c5f...

@bors
Copy link
Contributor

bors commented Jun 9, 2017

💔 Test failed - status-appveyor

@kennytm
Copy link
Member

kennytm commented Jun 9, 2017

i686-pc-windows-gnu this time, spurious, #41006.

Testing librustc stage2 (i686-pc-windows-gnu -> i686-pc-windows-gnu)
…
error: failed to remove: C:\projects\rust\build\i686-pc-windows-gnu\stage1-rustc\i686-pc-windows-gnu\release\rustc_trans.dll
Build failed, waiting for other jobs to finish...
error: build failed

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 9, 2017
@frewsxcv frewsxcv closed this Jun 9, 2017
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants