incr.comp.: Don't use Ident in DefPath because that's unstable across compilation sessions #42627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compilation sessions.
eddyb
reviewed
Jun 13, 2017
| pub fn get_opt_name(&self) -> Option<ast::Name> { | ||
| self.get_opt_ident().map(|ident| ident.name) | ||
| } | ||
|
|
||
| pub fn as_interned_str(&self) -> InternedString { |
There was a problem hiding this comment.
It'd be nice not to have the duplication between this and get_opt_name.
There was a problem hiding this comment.
Would be nice, but they are not quite the same...
|
@bors r+ |
|
📌 Commit d714b97 has been approved by |
|
This seems like we'd want perf stats for it as well. @bors p=100 |
bors
added a commit
that referenced
this pull request
Jun 13, 2017
incr.comp.: Don't use Ident in DefPath because that's unstable across compilation sessions Fixes #42550. cc @jseyfried @nikomatsakis r? @eddyb
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42550.
cc @jseyfried @nikomatsakis
r? @eddyb