-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run check-linkchecker when actually building docs #42651
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Thanks for the PR @infinity0, we'll make sure @alexcrichton or another reviewer gets to this soon! |
Thanks @infinity0! It looks like there's a stray jemalloc update here, but otherwise looks good to me! If you're feeling extra intrepid you could add a test at the end of |
Otherwise the build fails, when running tests but not building docs, e.g.: https://buildd.debian.org/status/fetch.php?pkg=rustc&arch=ppc64el&ver=1.17.0%2Bdfsg2-3&stamp=1497403375&raw=0
Whoops, fixed the jemalloc thing. I thought that test was too minor to bother with, but instead I've done a more sophisticated test to check that none of the steps' dependencies contain "doc-" or "default:doc", this will catch any future targets too. The test commit goes before the fix commit so you can check that it does indeed fail when the fix is not applied. Also, I'm not sure what Rust naming conventions are so I called it |
@bors: r+ Thanks! |
📌 Commit 13b1a80 has been approved by |
@bors rollup |
Only run check-linkchecker when actually building docs Otherwise the build fails, when running tests but not building docs, e.g.: https://buildd.debian.org/status/fetch.php?pkg=rustc&arch=ppc64el&ver=1.17.0%2Bdfsg2-3&stamp=1497403375&raw=0
Otherwise the build fails, when running tests but not building docs, e.g.:
https://buildd.debian.org/status/fetch.php?pkg=rustc&arch=ppc64el&ver=1.17.0%2Bdfsg2-3&stamp=1497403375&raw=0