-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for a few issues. #42724
Add tests for a few issues. #42724
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
src/test/compile-fail/issue-39553.rs
Outdated
struct FragmentKey; | ||
struct Fragment; | ||
|
||
pub fn iter() -> impl Iterator<Item=(&FragmentKey, &Box<Fragment>)> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue says that the ICE occurs when the lifetime elision is valid. When we add an argument here to make the elision valid(for example, v: &usize
), we get an ICE. At the issue it was &self
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. I will remove this test case tomorrow then and unmark the issue as E-needstest.
@bors: r+ |
📌 Commit 622e8c0 has been approved by |
@bors rollup |
Add tests for a few issues. Fixes rust-lang#41998 Fixes rust-lang#38381 Fixes rust-lang#37515 Fixes rust-lang#37510 Fixes rust-lang#37508 Fixes rust-lang#37366 Fixes rust-lang#37323 Fixes rust-lang#37051 Fixes rust-lang#36839 Fixes rust-lang#35570 Fixes rust-lang#34373 Fixes rust-lang#34222 Certainly not all of the E-needstest issues right now, but I started to get bored.
⌛ Testing commit 622e8c0 with merge e087d609c1a847c04ecf01ce032cf3a2463ab9d0... |
💔 Test failed - status-travis |
Ignored emscripten. @bors r=alexcrichton |
📌 Commit 9d3d4fb has been approved by |
⌛ Testing commit 9d3d4fb4642fb5d424a4e4bd7570bb989ac3edf7 with merge c5484529461f708137f2d8c6cf67cd7ac64fd224... |
💔 Test failed - status-appveyor |
err @bors r=alexcrichton |
📌 Commit 2346169 has been approved by |
⌛ Testing commit 2346169 with merge 6350316f22d5c18012f57448ac66fa390b45037d... |
💔 Test failed - status-travis |
@bors retry os x timed out |
So beautiful 😂 |
⌛ Testing commit 2346169 with merge 33a2208ebf913d6927fe650278843f9497013975... |
💔 Test failed - status-travis |
How hard is it to just add some regression tests, really? @bors retry |
☀️ Test successful - status-appveyor, status-travis |
Fixes #41998
Fixes #38381
Fixes #37515
Fixes #37510
Fixes #37366
Fixes #37323
Fixes #37051
Fixes #36839
Fixes #35570
Fixes #34373
Fixes #34222
Certainly not all of the E-needstest issues right now, but I started to get bored.