Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relaxed Debug constraints on {HashMap,BTreeMap}::{Keys,Values}. #42854

Merged
merged 2 commits into from
Jun 24, 2017
Merged

Relaxed Debug constraints on {HashMap,BTreeMap}::{Keys,Values}. #42854

merged 2 commits into from
Jun 24, 2017

Conversation

razielgn
Copy link
Contributor

@razielgn razielgn commented Jun 23, 2017 •
edited
Loading

I was hit by this yesterday too. 😄
And I've realised that Debug for BTreeMap::{Keys,Values} wasn't formatting just keys and values respectively, but the whole map. 🤔

Fixed #41924

r? @jonhoo

@razielgn razielgn changed the title Relaxed debug constraints on maps iterators Relaxed debug constraints on {HashMap,BTreeMap}::{Keys,Values}. Jun 23, 2017
@razielgn razielgn changed the title Relaxed debug constraints on {HashMap,BTreeMap}::{Keys,Values}. Relaxed Debug constraints on {HashMap,BTreeMap}::{Keys,Values}. Jun 23, 2017
@jonhoo
Copy link
Contributor

jonhoo commented Jun 23, 2017

I'm not sure why the removal of .inner for BTreeMap is necessary, but apart from that it looks good to me. Can't r+ though since I'm not a member of the rust team :)

@Mark-Simulacrum
Copy link
Member

r? @sfackler

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jun 23, 2017
@razielgn
Copy link
Contributor Author

As far as I understood, the .inner is an iterator on the full map, while self implements an iterator on just keys/values. Long story short, {:?} on Keys/Values was printing the full map, not just the keys/values.
Sorry about the r?, now I get how it works. 😄

@sfackler
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 23, 2017

📌 Commit 545bfcd has been approved by sfackler

@frewsxcv
Copy link
Member

@bors rollup

@bors
Copy link
Contributor

bors commented Jun 24, 2017

⌛ Testing commit 545bfcd with merge 7e76505...

bors added a commit that referenced this pull request Jun 24, 2017
@bors
Auto merge of #42854 - razielgn:relaxed-debug-constraints-on-maps-ite…
7e76505 
…rators, r=sfackler

Relaxed Debug constraints on {HashMap,BTreeMap}::{Keys,Values}.

I has hit by this yesterday too. 😄
And I've realised that Debug for BTreeMap::{Keys,Values} wasn't formatting just keys and values respectively, but the whole map. 🤔

Fixed #41924

r? @jonhoo
@bors
Copy link
Contributor

bors commented Jun 24, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: sfackler
Pushing 7e76505 to master...

@bors bors merged commit 545bfcd into rust-lang:master Jun 24, 2017
@razielgn razielgn deleted the relaxed-debug-constraints-on-maps-iterators branch June 24, 2017 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sfackler sfackler

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@razielgn @jonhoo @Mark-Simulacrum @sfackler @bors @frewsxcv