Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword OsStr docs to clarify that utf8 may contain nulls #42905

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Reword OsStr docs to clarify that utf8 may contain nulls #42905

merged 1 commit into from
Jun 27, 2017

Conversation

casey
Copy link
Contributor

@casey casey commented Jun 25, 2017

The use of the word "but" in the OsStr docs implies (at least to me) that valid UTF-8 does not contain null bytes.

Using "which" instead makes it clear that valid UTF-8 may contain null bytes.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2017
@carols10cents
Copy link
Member

Thanks for the PR! We’ll periodically check in on it to make sure that @aturon or someone else from the team reviews it soon.

@steveklabnik
Copy link
Member

@bors: r+ rollup

thanks!

@bors
Copy link
Collaborator

bors commented Jun 27, 2017

📌 Commit 0d985c9 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 27, 2017
@frewsxcv
Rollup merge of rust-lang#42905 - casey:casey-utf8-null-doc, r=stevek…
83d4b43 
…labnik

Reword OsStr docs to clarify that utf8 may contain nulls

The use of the word "but" in the OsStr docs implies (at least to me) that valid UTF-8 does not contain null bytes.

Using "which" instead makes it clear that valid UTF-8 may contain null bytes.
@frewsxcv frewsxcv mentioned this pull request Jun 27, 2017
Merged
bors added a commit that referenced this pull request Jun 27, 2017
@bors
Auto merge of #42922 - frewsxcv:rollup, r=frewsxcv
f590a44 
Rollup of 5 pull requests

- Successful merges: #42519, #42871, #42874, #42905, #42917
- Failed merges:
@bors bors merged commit 0d985c9 into rust-lang:master Jun 27, 2017
@casey
Copy link
Contributor Author

casey commented Jun 27, 2017

Thanks @steveklabnik and @bors!

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@casey @rust-highfive @carols10cents @steveklabnik @bors @aturon