Shift mir-dataflow from rustc_borrowck to rustc_mir crate.
#42924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
(I suspect we should not bother landing this until after issue #42903 is resolved, since we may need to revert the |
arielb1
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #42417) made this pull request unmergeable. Please resolve the merge conflicts. |
arielb1
reviewed
Jun 28, 2017
|
|
||
| pub struct SanityCheck; | ||
|
|
||
| impl MirPass for SanityCheck { |
Turn `elaborate_drops` and `rustc_peek` implementations into MIR passes that also live in `rustc_mir` crate. Rewire things so `rustc_driver` uses the `ElaborateDrops` from `rustc_mir` crate.
pnkfelix
added
S-waiting-on-author
|
@bors r=arielb1 |
|
📌 Commit 13cd022 has been approved by |
pnkfelix
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 30, 2017
Shift mir-dataflow from `rustc_borrowck` to `rustc_mir` crate. Shift mir-dataflow from `rustc_borrowck` to `rustc_mir` crate. Turn `elaborate_drops` and `rustc_peek` implementations into MIR passes that also live in `rustc_mir` crate. Rewire things so `rustc_driver` uses the `ElaborateDrops` from `rustc_mir` crate. (This PR is another baby step for mir-borrowck; it is a piece of work that other people want to rebase their stuff on top of, namely developers who are doing other dataflow analyses on top of MIR.) I have deliberately architected this PR in an attempt to minimize the number of actual code changes. The majority of the diff should be little more than changes to mod and use declarations, as well as a few visibility promotions to pub(crate) when a declaration was moved downward in the module hierarchy. (I have no problem with other PR's that move declarations around to try to clean this up; my goal was to ensure that the diff here was as small as possible, to make the review nearly trivial.)
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shift mir-dataflow from
rustc_borrowcktorustc_mircrate.Turn
elaborate_dropsandrustc_peekimplementations into MIR passes that also live inrustc_mircrate.Rewire things so
rustc_driveruses theElaborateDropsfromrustc_mircrate.(This PR is another baby step for mir-borrowck; it is a piece of work that other people want to rebase their stuff on top of, namely developers who are doing other dataflow analyses on top of MIR.)
I have deliberately architected this PR in an attempt to minimize the number of actual code changes. The majority of the diff should be little more than changes to mod and use declarations, as well as a few visibility promotions to pub(crate) when a declaration was moved downward in the module hierarchy.
(I have no problem with other PR's that move declarations around to try to clean this up; my goal was to ensure that the diff here was as small as possible, to make the review nearly trivial.)