Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase LLVM on top of LLVM 4.0.1 #42930

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Rebase LLVM on top of LLVM 4.0.1 #42930

merged 1 commit into from
Jun 30, 2017

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Jun 27, 2017

Fixes #42893.

Please don't backport this to beta as-is - I'm not sure I want rust-lang/llvm#84 to sneak to beta before it gets sufficient testing.

r? @alexcrichton

@Mark-Simulacrum
Copy link
Member

rust-lang/llvm@95ed1e1 seems to imply that stack coloring is disabled currently by-default anyway? Or do we re-enable that in another patch?

@arielb1
Copy link
Contributor Author

arielb1 commented Jun 27, 2017

rust-lang/llvm@95ed1e1 seems to imply that stack coloring is disabled currently by-default anyway? Or do we re-enable that in another patch?

That's just SafeStackColoring. Different pass. I actually have a Rust test that StackColoring works.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 27, 2017

📌 Commit 0e6eecb has been approved by alexcrichton

@arielb1 arielb1 added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 27, 2017
@bors
Copy link
Contributor

bors commented Jun 30, 2017

⌛ Testing commit 0e6eecb with merge 4c5b437...

bors added a commit that referenced this pull request Jun 30, 2017
Rebase LLVM on top of LLVM 4.0.1

Fixes #42893.

Please don't backport this to beta as-is - I'm not sure I want rust-lang/llvm#84 to sneak to beta before it gets sufficient testing.

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Jun 30, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 4c5b437 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants