Rollup of 12 pull requests #42964
Merged
Rollup of 12 pull requests #42964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I reworded it slightly to make it more clear that the function only take two arguments - the output and the Arguments struct that can be generated from the format_args! macro. r? @steveklabnik
This rewords and removes the `Arguments` section from the docs for fmt::format. r? @steveklabnik
This change allows the user to add an `#[allow_fail]` attribute to tests that will cause the test to compile & run, but if the test fails it will not cause the entire test run to fail. The test output will show the failure, but in yellow instead of red, and also indicate that it was an allowed failure.
Should fix race rust-lang#42795
This had an accidental `u8 as *mut T` where it was intended to have just a normal pointer-to-pointer cast. Closes rust-lang#42827
From review discussion on rust-lang#38103 (rust-lang#38103 (comment)).
Expand Derivable docblock section for `Ord` and `PartialOrd` to cover `enum` types, in addition to the existing language explaining it for `struct` types.
… r=GuillaumeGomez add `allow_fail` test attribute This change allows the user to add an `#[allow_fail]` attribute to tests that will cause the test to compile & run, but if the test fails it will not cause the entire test run to fail. The test output will show the failure, but in yellow instead of red, and also indicate that it was an allowed failure. Here is an example of the output: http://imgur.com/a/wt7ga
Update docs for fmt::write. rust-lang#29355 I reworded it slightly to make it more clear that the function only take two arguments - the output and the Arguments struct that can be generated from the format_args! macro. r? @steveklabnik
Update docs for std::fmt::format rust-lang#29355. This rewords and removes the `Arguments` section from the docs for fmt::format. r? @steveklabnik
…crichton Move global vars changing tests into run-pass Should fix race rust-lang#42795
syntax: allow negative integer literal expression to be interpolated as pattern Fixes rust-lang#42820. r? @jseyfried
std: Fix implementation of `Alloc::alloc_one` This had an accidental `u8 as *mut T` where it was intended to have just a normal pointer-to-pointer cast. Closes rust-lang#42827
…the_first_time, r=eddyb make lint on-by-default/implied-by messages appear only once From review discussion on rust-lang#38103 (rust-lang#38103 (comment)).  r? @nikomatsakis
[libcore/cmp] Expand Ord/PartialOrd Derivable doc for enum types Expand Derivable docblock section for `Ord` and `PartialOrd` to cover `enum` types, in addition to the existing language explaining it for `struct` types.
compile-error.md: Fix link reference Was a copy-paste mistake, I guess
Move type parameter shadowing test to `ui` Fix rust-lang#20729.
Document that `/` works as separator on Windows
Hi Whenever I see code like `Path::new("./src/bin/main.rs")` or `path.ends_with("foo/bar")`, I wonder if it will work on Windows as I expect. Unfortunately, reading the current docs does not help to answer this question, because all examples are Unix-specific.
However, I believe that using `/` is fine, because both Windows itself [and Rust stdlib](https://github.com/rust-lang/rust/blob/47faf1d51952ecd9d4c8a7325332fba34fbe00bd/src/libstd/sys/windows/path.rs#L26) do treat it as a file separator, and because it is [actually used](https://github.com/rust-lang/cargo/blob/abf01e1eddb3145c83f71b469ea7bee37141e5e1/tests/git.rs#L579) in Cargo. So looks like we can just document it?
r? @steveklabnik
cc @retep998 I don't actually program for windows that much, so I might be totally wrong, and perhaps we should advise to always use (allocating) `.join` method to construct paths of more than one component?
…k-Simulacrum Better timestamps in builds r? @Mark-Simulacrum
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=10 |
|
📌 Commit d3329d7 has been approved by |
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow_failtest attribute #42219, Update docs for fmt::write. #42831, Update docs for std::fmt::format #29355. #42832, Move global vars changing tests into run-pass #42884, syntax: allow negative integer literal expression to be interpolated as pattern #42886, std: Fix implementation ofAlloc::alloc_one#42901, make lint on-by-default/implied-by messages appear only once #42919, [libcore/cmp] Expand Ord/PartialOrd Derivable doc for enum types #42920, compile-error.md: Fix link reference #42946, Move type parameter shadowing test toui#42953, Document that/works as separator on Windows #42955, Better timestamps in builds #42958