Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Stabilize RangeArgument" #42991

Merged
merged 1 commit into from
Jul 1, 2017

Conversation

sfackler
Copy link
Member

This reverts commit 143206d.

From the discussion in #30877 it seems like this is premature.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@sfackler
Copy link
Member Author

r? @alexcrichton

@clarfonthey
Copy link
Contributor

Could you leave Bound in core::ops for this? That move is definitely agreed upon, but RangeArgument is what has the discrepancy.

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2017
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 30, 2017

📌 Commit 0a9c136 has been approved by alexcrichton

@sfackler
Copy link
Member Author

sfackler commented Jul 1, 2017

@clarcharr yep, I'll move things to libcore in a separate PR - I think it'll be a bit less confusing to do it separately :)

bors added a commit that referenced this pull request Jul 1, 2017
Revert "Stabilize RangeArgument"

This reverts commit 143206d.

From the discussion in #30877 it seems like this is premature.
@bors
Copy link
Contributor

bors commented Jul 1, 2017

⌛ Testing commit 0a9c136 with merge a5d34e1...

@bors
Copy link
Contributor

bors commented Jul 1, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a5d34e1 to master...

@bors bors merged commit 0a9c136 into rust-lang:master Jul 1, 2017
@sfackler sfackler mentioned this pull request Jul 8, 2017
@sfackler sfackler deleted the unstable-rangeargument branch July 8, 2017 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants