Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a stability marker for core::cmp::Reverse.0 #43043

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Add a stability marker for core::cmp::Reverse.0 #43043

merged 1 commit into from
Jul 4, 2017

Conversation

sfackler
Copy link
Member

@sfackler sfackler commented Jul 3, 2017

Closes #43027

@sfackler sfackler added beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 3, 2017
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 3, 2017

📌 Commit dcd7c5f has been approved by Mark-Simulacrum

@petrochenkov
Copy link
Contributor

@sfackler
Could you keep #43027 open, it's a compiler bug if something legitimately public succesfully compiles without stability annotation.

@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 4, 2017
@Mark-Simulacrum
Copy link
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#43043 - sfackler:reverse-stability, r=Mark-…
5b86b35 
…Simulacrum

Add a stability marker for core::cmp::Reverse.0

Closes rust-lang#43027
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 4, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#43043 - sfackler:reverse-stability, r=Mark-…
f80e58a 
…Simulacrum

Add a stability marker for core::cmp::Reverse.0

Closes rust-lang#43027
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 4, 2017
Merged
bors added a commit that referenced this pull request Jul 4, 2017
@bors
Auto merge of #43051 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
2fbba5b 
Rollup of 8 pull requests

- Successful merges: #42227, #42836, #42975, #42994, #43041, #43042, #43043, #43045
- Failed merges:
@sfackler
Copy link
Member Author

sfackler commented Jul 4, 2017

@petrochenkov I think it'd make more sense to open a separate issue about the broader problem as opposed to this one instance.

@bors bors merged commit dcd7c5f into rust-lang:master Jul 4, 2017
@brson brson mentioned this pull request Jul 8, 2017
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 13, 2017
bors added a commit that referenced this pull request Jul 13, 2017
@bors
Auto merge of #43114 - brson:beta-next, r=brson
8537f4e 
[beta] backports

- #43068
- #43043
- #42745

The pick of 143206d in cfa3b58 was not clean and needed a fair bit of surgery. It should probably be looked at closely.

Still testing locally.
bors added a commit that referenced this pull request Jul 13, 2017
@bors
Auto merge of #43114 - brson:beta-next, r=alexcrichton
23542f5 
[beta] backports

- #43068
- #43043
- #42745

The pick of 143206d in cfa3b58 was not clean and needed a fair bit of surgery. It should probably be looked at closely.

Still testing locally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sfackler @rust-highfive @Mark-Simulacrum @bors @petrochenkov @alexcrichton @brson