Tidy: allow common lang+lib features #43247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows changes to the Rust language that have both library and language components share one feature gate. The feature gates need to be "about the same change", so that both library and language components must either be both unstable, or both stable, and share the tracking issue. Removes the ugly "proc_macro" exception. Closes rust-lang#43089
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 94fc09c has been approved by |
|
⌛ Testing commit 94fc09c with merge 1d375595c6a789318593f53fbbb183d9815ffd6b... |
|
💔 Test failed - status-travis |
|
@bors retry |
arielb1
added
S-waiting-on-bors
|
⌛ Testing commit 94fc09c with merge 7aeabc6a04819ff1681efc204df2dea277206e49... |
|
💔 Test failed - status-appveyor |
|
@bors retry -- intermittent network (service) issue or downtime |
|
⌛ Testing commit 94fc09c with merge 2a1fb5d3180258642ae600954201f21e770172d4... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
…On Wed, Jul 19, 2017 at 3:58 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.3971>
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#43247 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95Jkdq9boDmu-CZAGS_mvtPYQHgXtks5sPcUugaJpZM4OY6GL>
.
|
bors
added a commit
that referenced
this pull request
Jul 20, 2017
Tidy: allow common lang+lib features This allows changes to the Rust language that have both library and language components share one feature gate. The feature gates need to be "about the same change", so that both library and language components must either be both unstable, or both stable, and share the tracking issue. Removes the ugly "proc_macro" exception added by #40939. Closes #43089
|
☀️ Test successful - status-appveyor, status-travis |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows changes to the Rust language that have both library
and language components share one feature gate.
The feature gates need to be "about the same change", so that both
library and language components must either be both unstable, or
both stable, and share the tracking issue.
Removes the ugly "proc_macro" exception added by #40939.
Closes #43089