Skip to content

Fix range_covered_by_constructor for exclusive ranges. #43266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2017
Merged

Fix range_covered_by_constructor for exclusive ranges. #43266

merged 2 commits into from
Jul 17, 2017

Conversation

feadoor
Copy link
Contributor

@feadoor feadoor commented Jul 16, 2017

This resolves #43253

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@feadoor feadoor mentioned this pull request Jul 16, 2017
Closed
@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2017
@nikomatsakis
Copy link
Contributor

@bors r+ -- looks nice!

@bors
Copy link
Collaborator

bors commented Jul 17, 2017

📌 Commit 1b3c339 has been approved by nikomatsakis

nikomatsakis
nikomatsakis approved these changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. =)

@bors
Copy link
Collaborator

bors commented Jul 17, 2017

⌛ Testing commit 1b3c339 with merge 028569a...

bors added a commit that referenced this pull request Jul 17, 2017
@bors
Auto merge of #43266 - feadoor:issue-43253-exclusive-range-warning, r…
028569a 
…=nikomatsakis

Fix `range_covered_by_constructor` for exclusive ranges.

This resolves #43253
@bors
Copy link
Collaborator

bors commented Jul 17, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 028569a to master...

@bors bors merged commit 1b3c339 into rust-lang:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong compiler warning with exclusive_range_pattern feature
5 participants
@feadoor @rust-highfive @nikomatsakis @bors @Mark-Simulacrum