Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #43603

Merged
merged 23 commits into from
Aug 2, 2017
Merged

Rollup of 6 pull requests #43603

merged 23 commits into from
Aug 2, 2017

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Aug 2, 2017

alexcrichton and others added 23 commits July 21, 2017 09:44
@alexcrichton
Thread through the original error when opening archives
81eea9e 
This updates the management of opening archives to thread through the original
piece of error information from LLVM over to the end consumer, trans.
Add simple docs example for struct Cell
236b748
add prose
bb65d32
review fixes
3c53595
ci fix?
8286075
empty lines
beb072a
s/immutable/my_struct
d429a4e
@alexcrichton
rustc: Inline bitwise modification operators
dd371a2 
These need to be inlined across crates to avoid showing up as one-instruction
functions in profiles! In the benchmark from rust-lang#43578 this decreased the
translation item collection step from 30s to 23s, and looks like it also allowed
vectorization elsewhere of the operations!
Fix the Solaris pthread_t raw type in std to match what's in libc
bdb53e5 
The old type causes failures when building cargo 0.20.0 after
changeset 8304e06 in the libc repo.
@ibabushkin
Derive Hash on AssociatedKind.
1b831cf 
This is a trivial change useful in downstream code poking in rustc's
innards.
@frewsxcv
Add doc example for HashSet::hasher.
8810627
@frewsxcv
Show that the capacity changed in HashSet::reserve doc example.
9e19260
@frewsxcv
Indicate HashSet is code-like in docs.
070eb3c
@frewsxcv
Remove unnecessary 'mut' bindings.
9e2b0c6
@frewsxcv
Show the capacity in HashSet::with_capacity doc example.
1599fad
@frewsxcv
Remove unnecessary clones in doc examples.
34c1bfb
@frewsxcv
Add doc example for HashSet::drain.
d9df296
@frewsxcv
Rollup merge of rust-lang#43389 - alexcrichton:thread-error, r=michae…
ab3fb95 
…lwoerister

Thread through the original error when opening archives

This updates the management of opening archives to thread through the original
piece of error information from LLVM over to the end consumer, trans.
@frewsxcv
Rollup merge of rust-lang#43423 - xliiv:cell-example, r=steveklabnik
2d9893f 
Add simple docs example for struct Cell
@frewsxcv
Rollup merge of rust-lang#43581 - alexcrichton:inline-more, r=michael…
c96ce40 
…woerister

rustc: Inline bitwise modification operators

These need to be inlined across crates to avoid showing up as one-instruction
functions in profiles! In the benchmark from rust-lang#43578 this decreased the
translation item collection step from 30s to 23s, and looks like it also allowed
vectorization elsewhere of the operations!
@frewsxcv
Rollup merge of rust-lang#43585 - frewsxcv:frewsxcv-hashset-docs, r=s…
08c0bbd 
…teveklabnik,quietmisdreavus

Improve docs & doc examples for HashSet.

None
@frewsxcv
Rollup merge of rust-lang#43597 - dhduvall:master, r=alexcrichton
1c91c78 
Fix the Solaris pthread_t raw type in std to match what's in libc

The old type causes failures when building cargo 0.20.0 after rust-lang/libc@8304e06b5.
@frewsxcv
Rollup merge of rust-lang#43598 - ibabushkin:master, r=eddyb
368f1a8 
Derive `Hash` on `AssociatedKind`.

This is a trivial change useful in downstream code poking in rustc's
innards, in particular the semver verification tool I'm currently working on.

r? @eddyb
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

frewsxcv commented Aug 2, 2017

@bors r+ p=10

@bors
Copy link
Collaborator

bors commented Aug 2, 2017

📌 Commit 368f1a8 has been approved by frewsxcv

@bors
Copy link
Collaborator

bors commented Aug 2, 2017

⌛ Testing commit 368f1a8 with merge 4f3062c...

bors added a commit that referenced this pull request Aug 2, 2017
@bors
Auto merge of #43603 - frewsxcv:rollup, r=frewsxcv
4f3062c 
Rollup of 6 pull requests

- Successful merges: #43389, #43423, #43581, #43585, #43597, #43598
- Failed merges:
@bors
Copy link
Collaborator

bors commented Aug 2, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: frewsxcv
Pushing 4f3062c to master...

@bors bors merged commit 368f1a8 into rust-lang:master Aug 2, 2017
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@frewsxcv @rust-highfive @bors @brson @Centril @alexcrichton @ibabushkin