Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nomicon #43618

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Update nomicon #43618

merged 1 commit into from
Aug 3, 2017

Conversation

SimonSapin
Copy link
Contributor

(This should have been in #42959.)

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @frewsxcv (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Gankra
Copy link
Contributor

Gankra commented Aug 2, 2017

r=me (don't have those rights anymore)

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 3, 2017

📌 Commit a8858eb has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Aug 3, 2017

⌛ Testing commit a8858eb with merge c701ba6...

bors added a commit that referenced this pull request Aug 3, 2017
@bors
Auto merge of #43618 - SimonSapin:nomiconup, r=steveklabnik
c701ba6 
Update nomicon

(This should have been in #42959.)
@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 3, 2017
@bors
Copy link
Contributor

bors commented Aug 3, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing c701ba6 to master...

@bors bors merged commit a8858eb into rust-lang:master Aug 3, 2017
@SimonSapin SimonSapin deleted the nomiconup branch November 16, 2017 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SimonSapin @rust-highfive @Gankra @steveklabnik @bors @frewsxcv @aidanhs