Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String slice doc improvements. #43652

Merged
merged 3 commits into from
Aug 5, 2017
Merged

String slice doc improvements. #43652

merged 3 commits into from
Aug 5, 2017

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Aug 5, 2017

No description provided.

QuietMisdreavus
QuietMisdreavus reviewed Aug 5, 2017
View reviewed changes
src/liballoc/str.rs Outdated
/// assert!(v.get(..42).is_none());
/// let mut v = String::from("🗻∈🌏");
///
/// assert_eq!(Some("🗻"), v.get(0..4);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a close paren. This is what failed travis.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in the latest force push

@QuietMisdreavus
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 5, 2017

📌 Commit 6722185 has been approved by QuietMisdreavus

@bors
Copy link
Contributor

bors commented Aug 5, 2017

⌛ Testing commit 6722185 with merge 9f52ddb21a5ca13ab8e8228f1d4bb096d80315db...

@bors
Copy link
Contributor

bors commented Aug 5, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Aug 5, 2017

@bors retry #40240 🤔. sccache error while building LLVM on dist-s390x-linux. Spurious.

[00:06:02] sccache: encountered fatal error
[00:06:02] sccache: error : Invalid checksum
[00:06:02] sccache:  cause: Invalid checksum
[00:06:02] make[2]: *** [lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMFastISel.cpp.o] Error 254
[00:06:02] make[2]: *** Deleting file `lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMFastISel.cpp.o'
[00:06:02] make[2]: *** Waiting for unfinished jobs....
...
$ cat obj/tmp/sccache.log
WARN:sccache::cache::s3: Got AWS error: Error(BadHTTPStatus(NotFound), State { next_error: None })
WARN:sccache::cache::s3: Got AWS error: Error(BadHTTPStatus(NotFound), State { next_error: None })
ERROR:sccache::server: ["ARMFastISel.cpp.o"] fatal error: Error(Io(Error { repr: Custom(Custom { kind: Other, error: StringError("Invalid checksum") }) }), State { next_error: None })
ERROR:sccache::server: [Error(Io(Error { repr: Custom(Custom { kind: Other, error: StringError("Invalid checksum") }) }), State { next_error: None })] 	ARMFastISel.cpp.o
WARN:sccache::cache::s3: Got AWS error: Error(BadHTTPStatus(InternalServerError), State { next_error: None })
$ cat /tmp/sccache.log
cat: /tmp/sccache.log: No such file or directory

@bors
Copy link
Contributor

bors commented Aug 5, 2017

⌛ Testing commit 6722185 with merge 5a5a32a...

bors added a commit that referenced this pull request Aug 5, 2017
@bors
Auto merge of #43652 - frewsxcv:frewsxcv-str-examples, r=QuietMisdreavus
5a5a32a 
String slice doc improvements.

None
@bors
Copy link
Contributor

bors commented Aug 5, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing 5a5a32a to master...

@bors bors merged commit 6722185 into rust-lang:master Aug 5, 2017
@kennytm kennytm mentioned this pull request Aug 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuietMisdreavus QuietMisdreavus QuietMisdreavus left review comments

@GuillaumeGomez GuillaumeGomez Awaiting requested review from GuillaumeGomez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frewsxcv @QuietMisdreavus @bors @kennytm