make for_all_relevant_impls O(1) again
#43723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielb1
added
the
beta-nominated
arielb1
force-pushed
the
nonincremental-fast-reject
branch
from
82fdfaa
to
4c8683a
Compare
|
@bors p=100 (no rolling up) |
|
Presumably updates to submodules are unintentional? |
A change in rust-lang#41911 had made `for_all_relevant_impls` do a linear scan over all impls, instead of using an HashMap. Use an HashMap again to avoid quadratic blowup when there is a large number of structs with impls. I think this fixes rust-lang#43141 completely, but I want better measurements in order to be sure. As a perf patch, please don't roll this up.
arielb1
force-pushed
the
nonincremental-fast-reject
branch
from
4c8683a
to
453ad81
Compare
|
Yup. Fixed |
arielb1
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 453ad81 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 8, 2017
make `for_all_relevant_impls` O(1) again A change in #41911 had made `for_all_relevant_impls` do a linear scan over all impls, instead of using an HashMap. Use an HashMap again to avoid quadratic blowup when there is a large number of structs with impls. I think this fixes #43141 completely, but I want better measurements in order to be sure. As a perf patch, please don't roll this up. r? @eddyb beta-nominating because regression
|
☀️ Test successful - status-appveyor, status-travis |
|
cc @rust-lang/compiler, any thoughts about a backport here? |
|
This improved the memory usage of nearly all incremental-related benchmarks by up to 25%. 🌴 |
6 tasks
nikomatsakis
added
the
beta-accepted
|
Accepted for beta. Not so small, but very important compile time regression. cc @rust-lang/compiler |
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in #41911 had made
for_all_relevant_implsdo a linear scan overall impls, instead of using an HashMap. Use an HashMap again to avoid
quadratic blowup when there is a large number of structs with impls.
I think this fixes #43141 completely, but I want better measurements in
order to be sure. As a perf patch, please don't roll this up.
r? @eddyb
beta-nominating because regression