Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the driver API a little more useful for a tools shim #43730

Merged
merged 2 commits into from
Aug 10, 2017

Conversation

nrc
Copy link
Member

@nrc nrc commented Aug 8, 2017

@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@nrc
Copy link
Member Author

nrc commented Aug 8, 2017

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned arielb1 Aug 8, 2017
@eddyb
Copy link
Member

eddyb commented Aug 8, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Aug 8, 2017

📌 Commit 540a644 has been approved by eddyb

@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2017

[00:31:18]    Compiling rustdoc v0.0.0 (file:///checkout/src/librustdoc)
[00:31:23] error[E0061]: this function takes 3 parameters but 2 parameters were supplied
[00:31:23]    --> /checkout/src/librustdoc/core.rs:158:55
[00:31:23]     |
[00:31:23] 158 |     let krate = panictry!(driver::phase_1_parse_input(&sess, &input));
[00:31:23]     |                                                       ^^^^^^^^^^^^^ expected 3 parameters
[00:31:23] 
[00:31:25] error[E0061]: this function takes 3 parameters but 2 parameters were supplied
[00:31:25]   --> /checkout/src/librustdoc/test.rs:94:55
[00:31:25]    |
[00:31:25] 94 |     let krate = panictry!(driver::phase_1_parse_input(&sess, &input));
[00:31:25]    |                                                       ^^^^^^^^^^^^^ expected 3 parameters
[00:31:25] 
[00:31:25] error: aborting due to 2 previous errors

@bors r-

@arielb1 arielb1 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 8, 2017
@nrc
Copy link
Member Author

nrc commented Aug 9, 2017

@bors: r=eddyb

@bors
Copy link
Contributor

bors commented Aug 9, 2017

📌 Commit 8ba63a1 has been approved by eddyb

@nrc nrc added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2017
@bors
Copy link
Contributor

bors commented Aug 9, 2017

⌛ Testing commit 8ba63a1bc909d9f72f8d820a2c62b509cb12cdb3 with merge b0a47f7a9987e0285c3957c58ebb3eac62cf852f...

@bors
Copy link
Contributor

bors commented Aug 9, 2017

💔 Test failed - status-travis

@nrc nrc added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2017
@nrc
Copy link
Member Author

nrc commented Aug 9, 2017

@bors: r=eddyb

@bors
Copy link
Contributor

bors commented Aug 9, 2017

📌 Commit a9a181d has been approved by eddyb

@nrc nrc added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2017
@bors
Copy link
Contributor

bors commented Aug 10, 2017

⌛ Testing commit a9a181d with merge 57e720d...

bors added a commit that referenced this pull request Aug 10, 2017
Make the driver API a little more useful for a tools shim

Example use case: https://github.com/nrc/rls-rustc
@bors
Copy link
Contributor

bors commented Aug 10, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 57e720d to master...

@bors bors merged commit a9a181d into rust-lang:master Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants