Fix include! in doc tests #43782
Merged
Fix include! in doc tests #43782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, rather than a dummy name
|
r? @frewsxcv (rust_highfive has picked a reviewer for you, use r? to override) |
nrc
added
A-libtest
Mark-Simulacrum
added
the
T-dev-tools
alexcrichton
added
the
S-waiting-on-review
|
Reassigning to someone on devtools |
|
Thanks! @bors: r+ |
|
📌 Commit 6d736df has been approved by |
|
@bors: rollup |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 13, 2017
Fix include! in doc tests By making the path relative to the current file. Fixes rust-lang#43153 [breaking-change] - if you use `include!` inside a doc test, you'll need to change the path to be relative to the current file rather than relative to the working directory.
bors
added a commit
that referenced
this pull request
Aug 13, 2017
nrc
added
beta-accepted
alexcrichton
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Aug 19, 2017
Uplift fix for include! in doc tests to beta Uplift #43782 to beta. Fixes #43153. r? @alexcrichton (approved by @rust-lang/dev-tools )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making the path relative to the current file.
Fixes #43153
[breaking-change] - if you use
include!inside a doc test, you'll need to change the path to be relative to the current file rather than relative to the working directory.