Remove ret_style #4382
Closed
Remove ret_style #4382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches over to using structs and send_maps for query string parsing.
For example, in let x: char = 42; This was an ICE and is now a proper type error, as per rust-lang#3477
Fix example in FFI tutorial.
Fix example in 13.3.
std: modernize net_url
update after/syntax/rust.vim for removal of <-
bump 0.5 => 0.6, redirect some URLs in docs.
update mandelbrot to pipes, a few other updates
Fix a bug in Result::unwrap_err (and minor cleanup)
Convert core::io to use explicit self (for issue rust-lang#4118 and issue rust-lang#2004)
Mark some more core and std functions as pure
...as far as I know, anyway, so I xfailed this tutorial test.
Before, the type was just the enum type itself, which caused an assertion failure in iter_variant in trans::base. r=brson Closes rust-lang#4229
Trivial cleanup: use enum_is_univariant; no functional change intended.
~20% perf win for trans on -O0, with other minor improvements across the board. No effect on -O2.
Modernize core::extfmt::ct
… ty_err In general it would be good to suppress any messages involving types that have ty_err as a sub-component, but this works for now.
This reverts commit d771830.
That is, treat `self` as if it has dynamic scope. This seems to be harmless, and prevents an ICE as per rust-lang#3563
This reverts commit c662a9a.
This reverts commit 921393c.
…esult is ty_err" This reverts commit e45312e.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 15, 2021
This commit partially reverts rust-lang#3934, opting to create a span that covers the entire body of a closure when formatting a closure body with a block-formatting strategy, rather than having the block-formatting code determine if the visitor pointer should be rewound. The problem with rewinding the visitor pointer is it may be incorrect for other (i.e. non-artificial) AST nodes, as in the case of rust-lang#4382. Closes rust-lang#4382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered issue #3681 on my branch improving fn inference. Here is a fix.
r? @catamorphism