rustc: Add Local to the HIR map of parents
#43971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
reviewed
Aug 18, 2017
src/test/run-pass/issue-43910.rs
Outdated
| @@ -0,0 +1,16 @@ | |||
| // Copyright 2017cThe Rust Project Developers. See the COPYRIGHT | |||
There was a problem hiding this comment.
Needs to remove the "c".
[00:03:51] tidy error: /checkout/src/test/run-pass/issue-43910.rs: incorrect license
alexcrichton
force-pushed
the
lint-statements
branch
from
95ccdc4
to
a175573
Compare
|
The UI test for error[E0507]: cannot move out of indexed content
--> $DIR/issue-40402-1.rs:19:13
|
19 | let e = f.v[0];
- | ^^^^^^
- | |
- | cannot move out of indexed content
- | help: consider using a reference instead: `&f.v[0]`
+ | - ^^^^^^ cannot move out of indexed content
+ | |
+ | hint: to prevent move, use `ref e` or `ref mut e`
error: aborting due to previous error |
When walking parents for lints we want to be sure to hit `let` statements which can have attributes, so hook up these statements in the HIR map. Closes rust-lang#43910
alexcrichton
force-pushed
the
lint-statements
branch
from
a175573
to
4ba2df1
Compare
|
Fixed |
|
@bors r+ Thanks, Alex! |
|
📌 Commit 4ba2df1 has been approved by |
|
⌛ Testing commit 4ba2df1 with merge 1bcf6f6b6cc2b88ab79fcc054ef4a850b5ca170e... |
|
💔 Test failed - status-travis |
|
@bors retry
|
|
⌛ Testing commit 4ba2df1 with merge de3926901219c14d84062c9020c931c0ae8a9955... |
|
bors
added a commit
that referenced
this pull request
Aug 21, 2017
rustc: Add `Local` to the HIR map of parents When walking parents for lints we want to be sure to hit `let` statements which can have attributes, so hook up these statements in the HIR map. Closes #43910
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When walking parents for lints we want to be sure to hit
letstatements whichcan have attributes, so hook up these statements in the HIR map.
Closes #43910