-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc: Remove some dead code #43986
rustc: Remove some dead code #43986
Conversation
/// data of *which* particular statement causing the deinitialization | ||
/// that the borrow checker's error message may need to report. | ||
#[allow(dead_code)] | ||
pub struct MovingOutStatements<'a, 'tcx: 'a> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is supposed to be used by MIR borrowck.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its okay, this is easy to put back when the time comes.
r? @pnkfelix |
LGTM except for some MIR changes - I'm not sure if anyone has plans for that code. |
/// constraint, and the nodes themselves are associated with | ||
/// variables or other bitsets. This method facilitates such a | ||
/// computation. | ||
pub fn iterate_until_fixed_point<'a, F>(&'a self, mut op: F) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was pretty surprised that this is dead code. But as far as I can tell, #7688 introduced it alongside with another fixed-point iteration function definition (specialized to region inference alone) ... and I guess no one ended up ever invoking the one that used the new graph abstraction ... Maybe that was meant to be future work that never got done? Anyway, I don't object to removing it now.
@bors r+ |
📌 Commit de4dbe5 has been approved by |
☀️ Test successful - status-appveyor, status-travis |
Extracted from #43192
r? @eddyb