clear out projection subobligations after they are processed #43999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaloJaffre
reviewed
Aug 20, 2017
src/librustc/traits/project.rs
Outdated
| } | ||
| }; | ||
|
|
||
| // Now that the |
nikomatsakis
approved these changes
Aug 21, 2017
src/librustc/traits/fulfill.rs
Outdated
| @@ -475,7 +475,8 @@ fn process_predicate<'a, 'gcx, 'tcx>( | |||
| trait_ref_type_vars(selcx, data.to_poly_trait_ref(tcx)); | |||
| Ok(None) | |||
| } | |||
| Ok(v) => Ok(v), | |||
| // FIXME: call ProjectionCache::complete when we can. | |||
There was a problem hiding this comment.
This would basically be when the obligation forest decides we are done with a projection predicate, right? In other words, the FIXME is sort of in the wrong place? I would expect us to iterate over outcome.completed (elsewhere in fulfill.rs...) and invoke complete() from there.
|
@arielb1 should this be nominated for a backport? |
|
@alexcrichton I think that @arielb1 backed out the relevant code for beta, so this applies to nightly only. |
aidanhs
added
the
S-waiting-on-author
After a projection was processed, its derived subobligations no longer need any processing when encountered, and can be removed. This improves the status of rust-lang#43787. This is actually complementary to rust-lang#43938 - that PR fixes selection caching (and @remram44's example, which "accidentally" worked because of the buggy projection caching) while this PR fixes projection caching
arielb1
force-pushed
the
immediate-project
branch
from
962ffb2
to
7534f73
Compare
|
Added comments. |
arielb1
added a commit
to arielb1/rust
that referenced
this pull request
Aug 27, 2017
This allows caching closure signatures and kinds in the normal selection and evaluation caches, and fixes the exponential worst-case in @remram44's example, which is a part of rust-lang#43787. This improvement is complenentary to rust-lang#43999 - they fix different cases.
nikomatsakis
approved these changes
Aug 28, 2017
|
@bors r+ |
|
📌 Commit 7534f73 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 28, 2017
clear out projection subobligations after they are processed After a projection was processed, its derived subobligations no longer need any processing when encountered, and can be removed. This improves the status of #43787. This is actually complementary to #43938 - that PR fixes selection caching (and @remram44's example, which "accidentally" worked because of the buggy projection caching) while this PR fixes projection caching. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
arielb1
added
the
beta-nominated
|
beta-nominating for 1.21 |
arielb1
added a commit
to arielb1/rust
that referenced
this pull request
Aug 29, 2017
This allows caching closure signatures and kinds in the normal selection and evaluation caches, and fixes the exponential worst-case in @remram44's example, which is a part of rust-lang#43787. This improvement is complenentary to rust-lang#43999 - they fix different cases.
bors
added a commit
that referenced
this pull request
Aug 31, 2017
[beta] Track closure signatures & kinds in freshened types This allows caching closure signatures and kinds in the normal selection and evaluation caches, and fixes the exponential worst-case in @remram44's example, which is a part of #43787. This improvement is complenentary to #43999 - they fix different cases. This is the pre-generators variation of #43938, cloned for beta.
alexcrichton
added
the
T-compiler
nikomatsakis
added
the
beta-accepted
|
Marking as beta-accepted. Medium patch, but important. cc @rust-lang/compiler |
|
Backporting now. |
alexcrichton
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Sep 28, 2017
Beta 20170928 Backports of: - Allow unused extern crate again #44825 - macros: fix bug in collecting trait and impl items with derives. #44757 - `--cap-lints allow` switches off `can_emit_warnings` #44627 - Update the libc submodule #44116 - limit and clear cache obligations opportunistically #44269 - clear out projection subobligations after they are processed #43999
bors
added a commit
that referenced
this pull request
Oct 7, 2017
Beta 20170928 Backports of: - Allow unused extern crate again #44825 - macros: fix bug in collecting trait and impl items with derives. #44757 - `--cap-lints allow` switches off `can_emit_warnings` #44627 - Update the libc submodule #44116 - limit and clear cache obligations opportunistically #44269 - clear out projection subobligations after they are processed #43999 - fix logic error in #44269's `prune_cache_value_obligations` #45065 - REVERTS #43543: Cleanup some remains of `hr_lifetime_in_assoc_type` compatibility lint:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a projection was processed, its derived subobligations no longer
need any processing when encountered, and can be removed. This improves
the status of #43787.
This is actually complementary to #43938 - that PR fixes selection
caching (and @remram44's example, which "accidentally" worked because of
the buggy projection caching) while this PR fixes projection caching.
r? @nikomatsakis