Do not assume libunwind.a is available on musl #44070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors p=1 |
|
@bors: r+ |
|
📌 Commit 3a8b00d has been approved by |
alexcrichton
added
the
S-waiting-on-bors
|
⌛ Testing commit 3a8b00d654d23d13484979a95ab873bd75f24a4f with merge c309b6f5378c92cef3584bc4ab85e06e350ab4ee... |
|
💔 Test failed - status-travis |
|
Want to just put a cfg on the attribute to avoid ever emitting the attribute on mips for now? |
|
@alexcrichton Yes, doing that now |
|
@bors: r+ |
|
📌 Commit dbcaf6c has been approved by |
|
⌛ Testing commit dbcaf6c with merge 65c2ad6777c21cef7e51e1613713026857199d6b... |
|
💔 Test failed - status-travis |
bors
added a commit
that referenced
this pull request
Aug 25, 2017
Do not assume libunwind.a is available on musl Fixes #40113, #44069, and clux/muslrust#16. libunwind.a is not copied from musl_root, so it must be integrated into the unwind crate.
|
☀️ Test successful - status-appveyor, status-travis |
|
Thanks again for the quick fix @smaeul! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40113, #44069, and clux/muslrust#16.
libunwind.a is not copied from musl_root, so it must be integrated into the unwind crate.