Skip to content

Use a byte literal ASCII 0 instead of its decimal value #44158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2017
Merged

Use a byte literal ASCII 0 instead of its decimal value #44158

merged 1 commit into from
Aug 30, 2017

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Aug 29, 2017

@SimonSapin noticed this in dtolnay/itoa#8.

@rust-highfive
Copy link
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@sfackler
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 29, 2017

📌 Commit 4312ed7 has been approved by sfackler

@arielb1 arielb1 added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 29, 2017
arielb1 pushed a commit to arielb1/rust that referenced this pull request Aug 29, 2017
Rollup merge of rust-lang#44158 - dtolnay:zero48, r=sfackler
a5e3484 
Use a byte literal ASCII 0 instead of its decimal value

@SimonSapin noticed this in dtolnay/itoa#8.
@arielb1 arielb1 mentioned this pull request Aug 29, 2017
Closed
@arielb1 arielb1 mentioned this pull request Aug 29, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Aug 29, 2017
Rollup merge of rust-lang#44158 - dtolnay:zero48, r=sfackler
be0ac01 
Use a byte literal ASCII 0 instead of its decimal value

@SimonSapin noticed this in dtolnay/itoa#8.
@arielb1 arielb1 mentioned this pull request Aug 29, 2017
Merged
bors added a commit that referenced this pull request Aug 29, 2017
@bors
Auto merge of #44169 - arielb1:rollup, r=arielb1
c11f689 
Rollup of 12 pull requests

- Successful merges: #43705, #43778, #43918, #44076, #44117, #44121, #44126, #44134, #44135, #44141, #44144, #44158
- Failed merges:
@bors bors merged commit 4312ed7 into rust-lang:master Aug 30, 2017
@dtolnay dtolnay deleted the zero48 branch November 19, 2017 08:36
@dtolnay dtolnay added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sfackler sfackler

Labels

T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dtolnay @rust-highfive @sfackler @bors @arielb1