Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement From<&str> for Symbol. #44223

Closed
wants to merge 1 commit into from
Closed

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Aug 31, 2017

This lets us have fn foo<S: Into<Symbol>> bounds and accept both &str and existing Symbols.

r? @jseyfried

@jseyfried
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 31, 2017

📌 Commit 9988e79 has been approved by jseyfried

@Mark-Simulacrum
Copy link
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 1, 2017
Implement From<&str> for Symbol.

This lets us have `fn foo<S: Into<Symbol>>` bounds and accept both `&str` and existing `Symbol`s.

r? @jseyfried
bors added a commit that referenced this pull request Sep 1, 2017
Rollup of 10 pull requests

- Successful merges: #44192, #44199, #44202, #44203, #44205, #44207, #44209, #44223, #44230, #44231
- Failed merges:
@bors
Copy link
Contributor

bors commented Sep 1, 2017

☔ The latest upstream changes (presumably #44233) made this pull request unmergeable. Please resolve the merge conflicts.

@eddyb
Copy link
Member Author

eddyb commented Sep 1, 2017

This was merged (and git branch --merged says so) but GitHub doesn't get it. cc @rust-lang/infra

@eddyb eddyb closed this Sep 1, 2017
@eddyb eddyb deleted the symbol-from-str branch September 1, 2017 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants