-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustbuild: Remove invalid doctest from bootstrap.py #44268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors r+ -- I think I recently saw this fail on Travis, too, but the overall build didn't fail. Did you see the doctests failing locally and stopping the build in the entirety? |
📌 Commit 5499d2b has been approved by |
@Mark-Simulacrum I just find it annoying that the failing test appear before The strange thing is that even if the test failed, the return code is still 0 (success), so while it should stop the build, it doesn't. Also, I expect the content should be collapsed between |
5499d2b
to
13df0e9
Compare
Make sure that if the test is failed, the CI will stop the build.
13df0e9
to
4d06185
Compare
@Mark-Simulacrum OK now the |
Thanks! @bors r+ |
📌 Commit 4d06185 has been approved by |
@bors rollup (pretty sure it won't interfere other Rust code) |
…lacrum rustbuild: Remove invalid doctest from bootstrap.py
☀️ Test successful - status-appveyor, status-travis |
No description provided.