Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #44599

Closed
wants to merge 22 commits into from
Closed

Commits on Sep 11, 2017

  1. Configuration menu
    Copy the full SHA
    a095ee4 View commit details
    Browse the repository at this point in the history
  2. add test

    GuillaumeGomez committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    9c12e5d View commit details
    Browse the repository at this point in the history
  3. 1 Configuration menu
    Copy the full SHA
    79f888d View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2017

  1. bump gcc for bootstrap

    On Windows, the gcc crate would send /Wall to msvc, which would cause
    builds to get flooded with warnings, exploding compile times from one
    hour to more than 72! The gcc crate version 0.3.54 changes this behavior
    to send /W4 instead, which greatly cuts down on cl.exe flooding the
    command prompt window with warnings.
    QuietMisdreavus committed Sep 12, 2017
    Configuration menu
    Copy the full SHA
    81ebab6 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2017

  1. rustc: Spawn cmd /c emcc.bat explicitly

    In rust-lang#42436 the behavior for spawning processes on Windows was tweaked slightly to
    fix various bugs, but this caused rust-lang#42791 as a regression, namely that to spawn
    batch scripts they need to be manually spawned with `cmd /c` instead now. This
    updates the compiler to handle this case explicitly for Emscripten.
    
    Closes rust-lang#42791
    alexcrichton committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    5cad391 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2017

  1. bring TyCtxt into scope

    qmx committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    d3bbce7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    39c9a3d View commit details
    Browse the repository at this point in the history
  3. travis: Move sccache to the us-west-1 region

    Most of the other rust-lang buckets are in us-west-1 and I think the original
    bucket was just accidentally created in the us-east-1 region. Let's consolidate
    by moving it to the same location as the rest of our buckets.
    alexcrichton committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    ddd321d View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2017

  1. bring TyCtxt into scope

    qmx committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    2bde694 View commit details
    Browse the repository at this point in the history
  2. bring Ty into scope

    qmx committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    3fe4612 View commit details
    Browse the repository at this point in the history
  3. rustc: Preallocate when building the dep graph

    This commit alters the `query` function in the dep graph module to preallocate
    memory using `with_capacity` instead of relying on automatic growth. Discovered
    in rust-lang#44576 it was found that for the syntex_syntax clean incremental benchmark
    the peak memory usage was found when the dep graph was being saved, particularly
    the `DepGraphQuery` data structure itself. PRs like rust-lang#44142 which add more
    queries end up just making this much larger!
    
    I didn't see an immediately obvious way to reduce the size of the
    `DepGraphQuery` object, but it turns out that `with_capacity` helps quite a bit!
    Locally 831 MB was used [before] this commit, and 770 MB is in use at the peak
    of the compiler [after] this commit. That's a nice 7.5% improvement! This won't
    quite make up for the losses in rust-lang#44142 but I figured it's a good start.
    
    [before]: https://gist.github.com/alexcrichton/2d2b9c7a65503761925c5a0bcfeb0d1e
    [before]: https://gist.github.com/alexcrichton/6da51f2a6184bfb81694cc44f06deb5b
    alexcrichton committed Sep 15, 2017
    Configuration menu
    Copy the full SHA
    a7817dd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    07494ec View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5398e03 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#44356 - nrc:rls-component-manifest, r=@alex…

    …crichton
    
    Attempt to fix the component manifest problem for rls-preview
    
    cc rust-lang#44270
    
    See rust-lang#44270
    GuillaumeGomez authored Sep 15, 2017
    Configuration menu
    Copy the full SHA
    0c39a5a View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#44397 - GuillaumeGomez:codeblock-color, r=Q…

    …uietMisdreavus
    
    Codeblock color
    
    <img width="1440" alt="screen shot 2017-09-07 at 21 53 58" src="https://user-images.githubusercontent.com/3050060/30183045-4319108e-9419-11e7-98da-da54952cab37.png">
    
    This screenshot has been generated from:
    
    ```rust
    /// foo
    ///
    /// ```compile_fail
    /// foo();
    /// ```
    ///
    /// ```ignore
    /// goo();
    /// ```
    ///
    /// ```
    /// let x = 0;
    /// ```
    pub fn bar() -> usize { 2 }
    ```
    
    r? @QuietMisdreavus
    cc @rust-lang/docs
    GuillaumeGomez authored Sep 15, 2017
    Configuration menu
    Copy the full SHA
    09baee8 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#44531 - QuietMisdreavus:bump-gcc, r=alexcri…

    …chton
    
    bump gcc for bootstrap
    
    On Windows, the gcc crate would send /Wall to msvc, which would cause
    builds to get flooded with warnings, exploding compile times from one
    hour to more than 72! The gcc crate version 0.3.54 changes this behavior
    to send /W4 instead, which greatly cuts down on cl.exe flooding the
    command prompt window with warnings.
    GuillaumeGomez authored Sep 15, 2017
    Configuration menu
    Copy the full SHA
    06f973b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#44542 - alexcrichton:fix-windows-emscripten…

    …, r=nikomatsakis
    
    rustc: Spawn `cmd /c emcc.bat` explicitly
    
    In rust-lang#42436 the behavior for spawning processes on Windows was tweaked slightly to
    fix various bugs, but this caused rust-lang#42791 as a regression, namely that to spawn
    batch scripts they need to be manually spawned with `cmd /c` instead now. This
    updates the compiler to handle this case explicitly for Emscripten.
    
    Closes rust-lang#42791
    GuillaumeGomez authored Sep 15, 2017
    Configuration menu
    Copy the full SHA
    cdc78e5 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#44560 - qmx:import-TyCtxt, r=eddyb

    bring TyCtxt into scope
    
    got comments both from @eddyb and @nikomatsakis (via rust-lang#44505) that we should always put `TyCtxt` in scope
    
    should I just go and import it at other places in the codebase or we just keep doing small improvements?
    GuillaumeGomez authored Sep 15, 2017
    Configuration menu
    Copy the full SHA
    6868419 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#44574 - alexcrichton:new-sccache-region, r=…

    …aidanhs
    
    travis: Move sccache to the us-west-1 region
    
    Most of the other rust-lang buckets are in us-west-1 and I think the original
    bucket was just accidentally created in the us-east-1 region. Let's consolidate
    by moving it to the same location as the rest of our buckets.
    GuillaumeGomez authored Sep 15, 2017
    Configuration menu
    Copy the full SHA
    00e8846 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#44586 - alexcrichton:smaller-query, r=micha…

    …elwoerister
    
    rustc: Preallocate when building the dep graph
    
    This commit alters the `query` function in the dep graph module to preallocate
    memory using `with_capacity` instead of relying on automatic growth. Discovered
    in rust-lang#44576 it was found that for the syntex_syntax clean incremental benchmark
    the peak memory usage was found when the dep graph was being saved, particularly
    the `DepGraphQuery` data structure itself. PRs like rust-lang#44142 which add more
    queries end up just making this much larger!
    
    I didn't see an immediately obvious way to reduce the size of the
    `DepGraphQuery` object, but it turns out that `with_capacity` helps quite a bit!
    Locally 831 MB was used [before] this commit, and 770 MB is in use at the peak
    of the compiler [after] this commit. That's a nice 7.5% improvement! This won't
    quite make up for the losses in rust-lang#44142 but I figured it's a good start.
    
    [before]: https://gist.github.com/alexcrichton/2d2b9c7a65503761925c5a0bcfeb0d1e
    [before]: https://gist.github.com/alexcrichton/6da51f2a6184bfb81694cc44f06deb5b
    GuillaumeGomez authored Sep 15, 2017
    Configuration menu
    Copy the full SHA
    56b3922 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#44589 - makotokato:thumb2, r=alexcrichton

    Require +thumb-mode to generate thumb2 code for Android/armv7-a
    
    I am investigating rust's code generation into Gecko by https://bugzilla.mozilla.org/show_bug.cgi?id=1399337.
    
    armv7-linux-androideabi target uses `+v7,+thumb2,+vfp3,+d16,-neon` as target-feature.  But `+thumb2` only doesn't generate thumb2 code.  To generate thumb2 code, it requires `+thumb-mode`.  So we should add it for armv7-linux-androideabi.
    
    r? @alexcrichton
    GuillaumeGomez authored Sep 15, 2017
    Configuration menu
    Copy the full SHA
    a0f6aaa View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#44593 - budziq:stabilize_ord_max_min, r=ale…

    …xcrichton
    
    stabilized ord_max_min (fixes rust-lang#25663)
    GuillaumeGomez authored Sep 15, 2017
    Configuration menu
    Copy the full SHA
    5e9b68f View commit details
    Browse the repository at this point in the history