-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of Travis's conditional jobs. #44631
Conversation
@bors try Let me verify if the try build works before merging. |
[DO NOT MERGE] Make use of Travis's conditional jobs. Conditional jobs: https://docs.travis-ci.com/user/conditional-builds-stages-jobs/#Conditional-Jobs. Jobs not matching the condition will not be scheduled at all. This allows us to get rid of `$ALLOW_PR`/`$ALLOW_TRY`/`$SKIP_BUILD` in `.travis.yml`, and perfectly prevent spurious PR failures due to flaky macOS machines.
OK try build works (?). The remaining thing is to ensure all 41 jobs are running during the actual test. EDIT: Not sure if relevant, but the try build failed to download the cache archive, causing 45 minutes spent on building docker. Maybe just due to removing the
|
r=me, but I want to run this past you as well. cc @rust-lang/infra as well. |
☀️ Test successful - status-travis |
That seems to be the case, see https://docs.travis-ci.com/user/caching/#Caches-and-build-matrices |
@bors: r+ Nice find! |
📌 Commit 9f76354 has been approved by |
…alexcrichton Make use of Travis's conditional jobs. Conditional jobs: https://docs.travis-ci.com/user/conditional-builds-stages-jobs/#Conditional-Jobs. Jobs not matching the condition will not be scheduled at all. This allows us to get rid of `$ALLOW_PR`/`$ALLOW_TRY`/`$SKIP_BUILD` in `.travis.yml`, and perfectly prevent spurious PR failures due to flaky macOS machines.
Conditional jobs: https://docs.travis-ci.com/user/conditional-builds-stages-jobs/#Conditional-Jobs.
Jobs not matching the condition will not be scheduled at all. This allows us to get rid of
$ALLOW_PR
/$ALLOW_TRY
/$SKIP_BUILD
in.travis.yml
, and perfectly prevent spurious PR failures due to flaky macOS machines.