ci: Disable rustc debug assertions on OSX #44641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disables debug assertions for OSX in an effort to improve cycle time on OSX. It looks like rust-lang#44610 didn't shave off quite as much time as desired so let's see how much this helps.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=1 (perf win, hopefully) |
|
📌 Commit c1a83ac has been approved by |
bors
added a commit
that referenced
this pull request
Sep 17, 2017
…rk-Simulacrum ci: Disable rustc debug assertions on OSX This commit disables debug assertions for OSX in an effort to improve cycle time on OSX. It looks like #44610 didn't shave off quite as much time as desired so let's see how much this helps.
|
☀️ Test successful - status-appveyor, status-travis |
|
Ok looks like this shaved ~10-15 minutes off the x86_64 build and ~5 minutes off the i686 build, but it's all still pretty variable. I'm tempted to leave this in, however, and see how it fares. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables debug assertions for OSX in an effort to improve cycle time
on OSX. It looks like #44610 didn't shave off quite as much time as desired so
let's see how much this helps.