Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove str_eq lang item #44658

Merged
merged 1 commit into from
Sep 23, 2017
Merged

Remove str_eq lang item #44658

merged 1 commit into from
Sep 23, 2017

Conversation

leoyvens
Copy link
Contributor

It's not really a lang item. Also remove outdated note. The reference uses this as an example so it has to be updated.

@leoyvens
Remove unused str_eq lang item
0741645 
It's not a lang item anymore. Also remove outdated note.
@leoyvens leoyvens mentioned this pull request Sep 17, 2017
Merged
@Mark-Simulacrum
Copy link
Member

r? @arielb1

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2017
@arielb1 arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2017
@arielb1
Copy link
Contributor

arielb1 commented Sep 19, 2017

@bors r+ rollup

Yeah, we moved to calling PartialEq::eq instead of having the lang item

@bors
Copy link
Contributor

bors commented Sep 19, 2017

📌 Commit 0741645 has been approved by arielb1

@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 21, 2017
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 21, 2017
@GuillaumeGomez
Rollup merge of rust-lang#44658 - leodasvacas:remove-str-eq-lang-item…
3cf088f 
…, r=arielb1

Remove str_eq lang item

It's not really a lang item. Also remove outdated note. The reference uses this as an example so it has to be updated.
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Sep 23, 2017
@frewsxcv
Rollup merge of rust-lang#44658 - leodasvacas:remove-str-eq-lang-item…
bdbe6e2 
…, r=arielb1

Remove str_eq lang item

It's not really a lang item. Also remove outdated note. The reference uses this as an example so it has to be updated.
@frewsxcv frewsxcv mentioned this pull request Sep 23, 2017
Merged
bors added a commit that referenced this pull request Sep 23, 2017
@bors
Auto merge of #44784 - frewsxcv:rollup, r=frewsxcv
85a5d3f 
Rollup of 14 pull requests

- Successful merges: #44554, #44648, #44658, #44712, #44717, #44726, #44745, #44746, #44749, #44759, #44770, #44773, #44776, #44778
- Failed merges:
@bors bors merged commit 0741645 into rust-lang:master Sep 23, 2017
@termoshtt termoshtt mentioned this pull request Nov 5, 2017
Closed
@leoyvens leoyvens deleted the remove-str-eq-lang-item branch March 7, 2018 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leoyvens @Mark-Simulacrum @arielb1 @bors @carols10cents