-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix run button #44671
Fix run button #44671
Conversation
35b5af5
to
90ce24a
Compare
Is this the right way to fix this? How'd this bug get introduced? |
Because of a position change in the |
Gotcha, thanks. @bors: r+ |
📌 Commit 90ce24a has been approved by |
@bors: p=1 |
⌛ Testing commit 90ce24a with merge c6d00f65142ebe7c56a411aa3c5dfaf9e687be4f... |
…labnik Fix run button r? @QuietMisdreavus Before: ![before](https://user-images.githubusercontent.com/3050060/30538927-612c6a44-9c70-11e7-9ca2-f3860d880b95.png) After: ![after](https://user-images.githubusercontent.com/3050060/30538929-6416ea0e-9c70-11e7-990a-7e4fbf5d7319.png) Quite urgent.
@bors: retry
|
⌛ Testing commit 90ce24a with merge 0da835202813349565ca7a7f17013a96fc85759d... |
…labnik Fix run button r? @QuietMisdreavus Before: ![before](https://user-images.githubusercontent.com/3050060/30538927-612c6a44-9c70-11e7-9ca2-f3860d880b95.png) After: ![after](https://user-images.githubusercontent.com/3050060/30538929-6416ea0e-9c70-11e7-990a-7e4fbf5d7319.png) Quite urgent.
@bors: retry prioritizing rollup again |
⌛ Testing commit 90ce24a with merge e856750b93231e34ec266b1c2558e4e83e43d388... |
@bors: retry
|
Thanks @alexcrichton! |
We need it for run buttons (rust-lang#44671), but not function defs
r? @QuietMisdreavus
Before:
After:
Quite urgent.