rustbuild: with --no-fail-fast, report the specific commands that failed #44680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @cuviper |
|
Looks good to me. @bors r+ p=1 (regression) |
|
📌 Commit 435a0ea has been approved by |
kennytm
requested changes
Sep 18, 2017
src/bootstrap/check.rs
Outdated
| @@ -68,8 +68,8 @@ impl fmt::Display for TestKind { | |||
| fn try_run_expecting(build: &Build, cmd: &mut Command, expect: BuildExpectation) { | |||
| if !build.fail_fast { | |||
| if !build.try_run(cmd, expect) { | |||
| let failures = build.delayed_failures.get(); | |||
| build.delayed_failures.set(failures + 1); | |||
| let mut failures = &mut build.delayed_failures.borrow_mut(); | |||
There was a problem hiding this comment.
&mut.
[00:01:54] error: variable does not need to be mutable
[00:01:54] --> /checkout/src/bootstrap/check.rs:71:17
[00:01:54] |
[00:01:54] 71 | let mut failures = &mut build.delayed_failures.borrow_mut();
[00:01:54] | ^^^^^^^^^^^^
[00:01:54] |
[00:01:54] note: lint level defined here
[00:01:54] --> /checkout/src/bootstrap/lib.rs:116:9
[00:01:54] |
[00:01:54] 116| #![deny(warnings)]
[00:01:54] | ^^^^^^^^
[00:01:54] = note: #[deny(unused_mut)] implied by #[deny(warnings)]
[00:01:54]
[00:01:54] error: variable does not need to be mutable
[00:01:54] --> /checkout/src/bootstrap/check.rs:86:17
[00:01:54] |
[00:01:54] 86 | let mut failures = &mut build.delayed_failures.borrow_mut();
[00:01:54] | ^^^^^^^^^^^^
[00:01:54]
[00:01:54] error: aborting due to 2 previous errors
[00:01:54]
[00:01:54] error: Could not compile `bootstrap`.
src/bootstrap/check.rs
Outdated
| @@ -83,8 +83,8 @@ fn try_run(build: &Build, cmd: &mut Command) { | |||
| fn try_run_quiet(build: &Build, cmd: &mut Command) { | |||
| if !build.fail_fast { | |||
| if !build.try_run_quiet(cmd) { | |||
| let failures = build.delayed_failures.get(); | |||
| build.delayed_failures.set(failures + 1); | |||
| let mut failures = &mut build.delayed_failures.borrow_mut(); | |||
|
@bors: r=Mark-Simulacrum |
|
📌 Commit 8f25497 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 18, 2017
rustbuild: with --no-fail-fast, report the specific commands that failed I'm not sure this is the most elegant way of doing it, I'm still a bit of a rust noob. I tried `Vec<Command>` and keeping `Cell` instead of `RefCell` but couldn't fight my way past the borrow errors, this was the first arrangement that I could make work.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the most elegant way of doing it, I'm still a bit of a rust noob. I tried
Vec<Command>and keepingCellinstead ofRefCellbut couldn't fight my way past the borrow errors, this was the first arrangement that I could make work.