Catch IOError in bootstrap.py when loading config.toml #44754
Conversation
If config.toml doesn't exist, then an IOError will be raised on the `with open(...)` line. Prior to e788fa7, this was caught because the `except` clause didn't specify what exceptions it caught, so both IOError and OSError were caught
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ Thanks! |
|
📌 Commit 5463aa0 has been approved by |
…-fix, r=alexcrichton Catch IOError in bootstrap.py when loading config.toml When I pulled this repo and tried to build using the command in the readme, I got an error about a missing `config.toml`. If config.toml doesn't exist, then an `IOError` will be raised the `with open(...)` line. Prior to e788fa7, this was caught because the `except` clause didn't specify what exceptions it caught, so both `IOError` and `OSError` were caught. First time contributing, so please let me know if I'm doing anything wrong.
…xcrichton Catch IOError in bootstrap.py when loading config.toml When I pulled this repo and tried to build using the command in the readme, I got an error about a missing `config.toml`. If config.toml doesn't exist, then an `IOError` will be raised the `with open(...)` line. Prior to e788fa7, this was caught because the `except` clause didn't specify what exceptions it caught, so both `IOError` and `OSError` were caught. First time contributing, so please let me know if I'm doing anything wrong.
|
☀️ Test successful - status-appveyor, status-travis |
When I pulled this repo and tried to build using the command in the readme, I got an error about a missing
config.toml.If config.toml doesn't exist, then an
IOErrorwill be raised thewith open(...)line. Prior to e788fa7, this was caught because theexceptclause didn't specify what exceptions it caught, so bothIOErrorandOSErrorwere caught.First time contributing, so please let me know if I'm doing anything wrong.